Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate blobber alloc removing #2264

Merged
merged 1 commit into from Apr 4, 2023
Merged

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Apr 3, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #2264 (a1f1928) into staging (6a4691f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2264      +/-   ##
===========================================
- Coverage    29.30%   29.29%   -0.01%     
===========================================
  Files          377      377              
  Lines        62549    62549              
===========================================
- Hits         18328    18322       -6     
- Misses       42065    42075      +10     
+ Partials      2156     2152       -4     
Flag Coverage 螖
Unit-Tests 29.29% <0.00%> (-0.01%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...go/0chain.net/smartcontract/storagesc/challenge.go 35.15% <0.00%> (酶)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit cc909af into staging Apr 4, 2023
8 checks passed
@dabasov dabasov deleted the fix/dup-alloc-rm-err branch April 4, 2023 13:01
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 420-system-tests-for-global-historic-metrics-for-graphs
gosdk staging
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not remove allocation from blobber
4 participants