New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vrfs attack Byzantine test #673
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #673 +/- ##
===========================================
- Coverage 27.09% 27.03% -0.06%
===========================================
Files 349 350 +1
Lines 57995 58087 +92
===========================================
- Hits 15713 15704 -9
- Misses 40379 40484 +105
+ Partials 1903 1899 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the expected result of this test? Is this test to check whether the miners blacklist the spamming miner?
I couldn't also get the spamming mechanism. Are we considering the spam mechanism to be the miner forcing the existence of 2 uncompleted rounds?
6d736b2
to
7ece67c
Compare
0cfa064
to
2a6e1b4
Compare
code/go/0chain.net/chaincore/chain/protocol_round_integration_tests.go
Outdated
Show resolved
Hide resolved
39fc22c
to
0596d78
Compare
@dabasov any other changes, you want me to do? |
@dabasov should we even track this? This has open without any activity since long. |
* Adversarial miner sends a VRF of a round before the previous one has been finalised. The rest of the miners continue working as expected.
596f546
to
584e116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job 👍
fixed as required
Add next integration test:
Check the created integration test by running the next commands.
Although not used it also adds a directive to check whether a round was finalized.