Skip to content

Add check for root #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2025
Merged

Add check for root #1543

merged 2 commits into from
Mar 30, 2025

Conversation

@Hitenjain14
Copy link
Contributor

@Hitenjain14 Hitenjain14 commented Mar 28, 2025

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Hitenjain14 Hitenjain14 marked this pull request as draft March 28, 2025 10:21
@Hitenjain14 Hitenjain14 marked this pull request as ready for review March 29, 2025 07:35
dabasov
dabasov approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit c3197e3 into staging Mar 30, 2025
4 of 6 checks passed
@dabasov dabasov deleted the fix/dirty-node branch March 30, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterlimg peterlimg Awaiting requested review from peterlimg

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

1 more reviewer

@dabasov dabasov dabasov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hitenjain14 @dabasov