169 grpc upload file handler #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shravanshetty1
changed the title
# Conflicts: # code/go/0chain.net/blobbercore/blobbergrpc/blobber.pb.go # code/go/0chain.net/blobbercore/blobbergrpc/blobber_grpc.pb.go # code/go/0chain.net/blobbercore/blobbergrpc/proto/blobber.proto # code/go/0chain.net/blobbercore/convert/responseHandler.go # code/go/0chain.net/blobbercore/mocks/PackageHandler.go
senpathi
changed the title
# Conflicts: # .github/workflows/ci.yml # code/go/0chain.net/blobbercore/allocation/allocationchange.go # code/go/0chain.net/blobbercore/blobbergrpc/blobber.pb.go # code/go/0chain.net/blobbercore/blobbergrpc/blobber_grpc.pb.go # code/go/0chain.net/blobbercore/blobbergrpc/proto/blobber.proto # code/go/0chain.net/blobbercore/convert/responseHandler.go # code/go/0chain.net/blobbercore/handler/helper.go # code/go/0chain.net/blobbercore/handler/object_operation_grpc_handler.go # code/go/0chain.net/blobbercore/handler/object_operation_grpc_handler_test.go # code/go/0chain.net/blobbercore/mocks/PackageHandler.go # code/go/0chain.net/blobbercore/openapi/blobber.swagger.json
shravanshetty1
suggested changes
Jun 21, 2021
Contributor
shravanshetty1
left a comment
shravanshetty1
left a comment
There was a problem hiding this comment.
Also for this endpoint, write integration tests in this PR itself
# Conflicts: # code/go/0chain.net/blobbercore/handler/grpc_handler_integration_test.go
test read file updated
shravanshetty1
suggested changes
Jun 30, 2021
| }; | ||
| } | ||
| rpc WriteFile(UploadFileRequest) returns (UploadFileResponse) { | ||
| option (google.api.http) = { |
Contributor
There was a problem hiding this comment.
why is method name different than request and response here?
Contributor
There was a problem hiding this comment.
Everything else is fine change this please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #169
upload file handler migrated to grpc
tests added