Adding grpc endpoints #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c28e36.
Move go.mod to parent directory
Integration tests to object operation handlers
Contributor
Author
|
@Sriep @andrenerd Please have a brief look at this to review general decisions, a detailed review is not required since there are tests already and its also being used in nine.devnet with no issues so far. |
andrenerd
approved these changes
Jul 7, 2021
GRPC refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an umbrella issue for adding grpc endpoints to blobber.
How can we verify this isnt causing breaking changes?
There are integration tests and it will also be deployed on one of the devnets for a few days to fix any minor bugs