Signature check support for collaborators on file update #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartie4
changed the title
stewartie4
changed the title
andrenerd
approved these changes
Jul 2, 2021
Sriep
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature checks were implemented under #66 and 0chain/gosdk#30 to fix #48
However, this has broken collaboration on the file upload endpoint (update operation) as the signature check is hardcoded against the allocation owner's public key. Therefore when a collaborator signs the request using their public key, signature verification will fail.
Fix:
If the client Id is a collaborator then use their public key (present in the request headers) to validate the signature.
If the client id is not a collaborator, we use the public key from the allocation as normal to prevent signature forgery
NB: The current codebase is very procedural so I've refactored a bit (more could be done)