Skip to content

fix(allocation):update NewConnectionId with zboxutil.NewConnectionId #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix(allocation):update NewConnectionId with zboxutil.NewConnectionId #289

merged 2 commits into from
Aug 5, 2021

Conversation

@cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Aug 4, 2021

fixed #288

@cnlangzi cnlangzi requested a review from Sriep August 4, 2021 14:28
kushthedude
kushthedude suggested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zboxutil generates the number in the same way too https://github.com/0chain/gosdk/blob/826e79c0eb2030c6ba1ada3f0aa7928c67e5d590/zboxcore/zboxutil/util.go#L85

kushthedude
kushthedude suggested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the logic at the Zboxutil then we can use the imported method over here

@cnlangzi
Copy link
Contributor Author

cnlangzi commented Aug 4, 2021

zboxutil generates the number in the same way too https://github.com/0chain/gosdk/blob/826e79c0eb2030c6ba1ada3f0aa7928c67e5d590/zboxcore/zboxutil/util.go#L85

it is fixed on 0chain/gosdk#179

@kushthedude
Copy link
Contributor

kushthedude commented Aug 4, 2021

zboxutil generates the number in the same way too https://github.com/0chain/gosdk/blob/826e79c0eb2030c6ba1ada3f0aa7928c67e5d590/zboxcore/zboxutil/util.go#L85

it is fixed on 0chain/gosdk#179

merge the PR, bump the gosdk, change the go.mod in blobber to use the latest sdk then the following PR should be merged else it will refer to same code.

moldis
moldis approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@moldis moldis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cnlangzi
Copy link
Contributor Author

cnlangzi commented Aug 5, 2021

zboxutil generates the number in the same way too https://github.com/0chain/gosdk/blob/826e79c0eb2030c6ba1ada3f0aa7928c67e5d590/zboxcore/zboxutil/util.go#L85

it is fixed on 0chain/gosdk#179

merge the PR, bump the gosdk, change the go.mod in blobber to use the latest sdk then the following PR should be merged else it will refer to same code.

done

@cnlangzi cnlangzi merged commit de66db8 into master Aug 5, 2021
@cnlangzi cnlangzi deleted the fix/connection_id branch August 5, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sriep Sriep Awaiting requested review from Sriep

2 more reviewers

@kushthedude kushthedude kushthedude requested changes

@moldis moldis moldis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NewConnectionID isn't global unique

4 participants

@cnlangzi @kushthedude @moldis