fix(lock):#294 fixed memory leak issue #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sounds good. Could you give some trace before your changes (with memory leak) and after, to be sure it's gone? |
moldis
reviewed
Aug 11, 2021
Contributor
moldis
left a comment
moldis
left a comment
There was a problem hiding this comment.
Requested the trace to identify memory leak
Sriep
suggested changes
Aug 12, 2021
Contributor
Sriep
left a comment
Sriep
left a comment
There was a problem hiding this comment.
This should have a unit test.
Contributor
Author
I have updated detail about memory leak on #294. I found this issue on code review , not runtime. And it is easy to understand why it is memory leak issue. Because mutex never be removed from memory. A data row is asking a mutex. It is an issue for a long-running blobber instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #294