Fix with revoked share

[moldis]

--revoke share didn't work since the last gosdk update. This fix should resolve it

[cnlangzi]

should we check err here? We need to know if db throw any error?

func GetShareInfo(ctx context.Context, clientID string, filePathHash string) (*ShareInfo, error) {
	db := datastore.GetStore().GetTransaction(ctx)
	shareInfo := &ShareInfo{}
	err := db.Table(TableName()).
		Where(&ShareInfo{
			ClientID:     clientID,
			FilePathHash: filePathHash,
		}).
		First(shareInfo).Error

	if err == gorm.ErrRecordNotFound {
		return nil, nil
	}
	if err != nil {
		return nil, err
	}
	return shareInfo, nil
}

[moldis]

Nope, it's wrong 'tricky' implementation that causes previous bugs. I removed this check from DB level

[cnlangzi]

app might crash if shareInfo is nil? It is better to check it first.

[moldis]

This is exactly what was done in the previous comment. It' can't be nil if err is nil.

[cnlangzi]

here is an example for my review. thanks

var ErrServiceUnavailable = errors.New("service unavailable")
if err != nil { //any network/db error
    if errors.Is(err, ErrHasNotShared) {
         return nil, err
    }
    traceid := logging.Error(err)
    return nil, errors.Throw(ErrServiceUnavailable,traceid)
}

if shareInfo == nil ||  shareInfo.Removed {
    return nil, ErrHasNotShared
}


var ErrHasNotShared = errors.New("client does not have permission to download the file. share revoked")


func GetShareInfo(ctx context.Context, clientID string, filePathHash string) (*ShareInfo, error) {
	db := datastore.GetStore().GetTransaction(ctx)
	shareInfo := &ShareInfo{}
	err := db.Table(TableName()).
		Where(&ShareInfo{
			ClientID:     clientID,
			FilePathHash: filePathHash,
		}).
		First(shareInfo).Error

	if err != nil {

    if errors.Is(err, gorm.ErrRecordNotFound) {
        return nil, ErrHasNotShared
    }

		return nil, err
	}
	return shareInfo, nil
}

[cnlangzi]

BTW, errors.Throw is in github.com/0chain/errors package.

[moldis]

@cnlangzi This has to be applied globally and it's not following my current logic for sharing