corrected the ActualFileSize attribute #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrudra
requested review from
peterlimg,
dabasov,
guruhubb and
cnlangzi
as code owners
|
Manual system tests [success] with the following config
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
(*Allocation).GetFileMeta() returns JSONString having property ActualFileSize
Upon refresh at frontend, allocation.listDir() is invoked which returns JSONString containing list where each obj has property actual_size. At gosdk, this actual_size=ActualSize.
When file is uploaded & completed is called, allocation.getFileMeta() is called, where we don't get actual_size, but we receive ActualFileSize.
Issue: ActualFileSize is "Size" attribute, but we required "ActualSize" to be displayed at frontend.