Skip to content
Permalink
Browse files
media: staging: atomisp: use list_splice_init in atomisp_compat_css20.c
Using list_splice_init() instead of entire while-loops
in atomisp_compat_css20.c.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
  • Loading branch information
Baokun Li authored and intel-lab-lkp committed Jun 16, 2021
1 parent c7d4c1f commit 05c714d7b4e1722a75f949e40c5305f3ba28d048
Showing 1 changed file with 5 additions and 30 deletions.
@@ -2144,42 +2144,17 @@ void atomisp_css_stop(struct atomisp_sub_device *asd,
}

/* move stats buffers to free queue list */
while (!list_empty(&asd->s3a_stats_in_css)) {
s3a_buf = list_entry(asd->s3a_stats_in_css.next,
struct atomisp_s3a_buf, list);
list_del(&s3a_buf->list);
list_add_tail(&s3a_buf->list, &asd->s3a_stats);
}
while (!list_empty(&asd->s3a_stats_ready)) {
s3a_buf = list_entry(asd->s3a_stats_ready.next,
struct atomisp_s3a_buf, list);
list_del(&s3a_buf->list);
list_add_tail(&s3a_buf->list, &asd->s3a_stats);
}
list_splice_init(&asd->s3a_stats_in_css, &asd->s3a_stats);
list_splice_init(&asd->s3a_stats_ready, &asd->s3a_stats);

spin_lock_irqsave(&asd->dis_stats_lock, irqflags);
while (!list_empty(&asd->dis_stats_in_css)) {
dis_buf = list_entry(asd->dis_stats_in_css.next,
struct atomisp_dis_buf, list);
list_del(&dis_buf->list);
list_add_tail(&dis_buf->list, &asd->dis_stats);
}
list_splice_init(&asd->dis_stats_in_css, &asd->dis_stats);
asd->params.dis_proj_data_valid = false;
spin_unlock_irqrestore(&asd->dis_stats_lock, irqflags);

for (i = 0; i < ATOMISP_METADATA_TYPE_NUM; i++) {
while (!list_empty(&asd->metadata_in_css[i])) {
md_buf = list_entry(asd->metadata_in_css[i].next,
struct atomisp_metadata_buf, list);
list_del(&md_buf->list);
list_add_tail(&md_buf->list, &asd->metadata[i]);
}
while (!list_empty(&asd->metadata_ready[i])) {
md_buf = list_entry(asd->metadata_ready[i].next,
struct atomisp_metadata_buf, list);
list_del(&md_buf->list);
list_add_tail(&md_buf->list, &asd->metadata[i]);
}
list_splice_init(&asd->metadata_in_css[i], &asd->asd->metadata[i]);
list_splice_init(&asd->metadata_ready[i], &asd->asd->metadata[i]);
}

atomisp_flush_params_queue(&asd->video_out_capture);

0 comments on commit 05c714d

Please sign in to comment.