Skip to content
Permalink
Browse files
isoc: mediatek: potential use of error pointer
The return value of devm_clk_get() needs to be checked.
To avoid use of error pointer in case of the failure of alloc.

Fixes: 6078c65 ("soc: mediatek: Refine scpsys to support multiple platform")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
  • Loading branch information
JiangJias authored and intel-lab-lkp committed Dec 17, 2021
1 parent 0f2ee77 commit 1b5bac7d5052521b10c6c7ab2279cbd8c31cd458
Showing 1 changed file with 10 additions and 4 deletions.
@@ -411,12 +411,16 @@ static int scpsys_power_off(struct generic_pm_domain *genpd)
return ret;
}

static void init_clks(struct platform_device *pdev, struct clk **clk)
static int init_clks(struct platform_device *pdev, struct clk **clk)
{
int i;

for (i = CLK_NONE + 1; i < CLK_MAX; i++)
for (i = CLK_NONE + 1; i < CLK_MAX; i++) {
clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
if (!clk[i])
return ERR_PTR(-ENOMEM);
}
return 0;
}

static struct scp *init_scp(struct platform_device *pdev,
@@ -426,7 +430,7 @@ static struct scp *init_scp(struct platform_device *pdev,
{
struct genpd_onecell_data *pd_data;
struct resource *res;
int i, j;
int i, j, ret;
struct scp *scp;
struct clk *clk[CLK_MAX];

@@ -481,7 +485,9 @@ static struct scp *init_scp(struct platform_device *pdev,

pd_data->num_domains = num;

init_clks(pdev, clk);
ret = init_clks(pdev, clk);
if (ret)
return ERR_PTR(-ENOMEM);

for (i = 0; i < num; i++) {
struct scp_domain *scpd = &scp->domains[i];

0 comments on commit 1b5bac7

Please sign in to comment.