Skip to content
Permalink
Browse files
net: sched: tapr: remove WARN_ON() in taprio_get_start_time()
There is a reproducible sequence from the userland that will trigger a WARN_ON()
condition in taprio_get_start_time, which causes kernel to panic if configured
as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by
userland-initiated syscalls.

Reported as bug on syzkaller:
https://syzkaller.appspot.com/bug?extid=d50710fd0873a9c6b40c

Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
Signed-off-by: Du Cheng <ducheng2@gmail.com>
  • Loading branch information
Du Cheng authored and intel-lab-lkp committed Apr 15, 2021
1 parent 7f75285 commit 274f557f95031e6965d9bb0ee67fdc22f2eb9b3a
Showing 1 changed file with 1 addition and 1 deletion.
@@ -996,7 +996,7 @@ static int taprio_get_start_time(struct Qdisc *sch,
* something went really wrong. In that case, we should warn about this
* inconsistent state and return error.
*/
if (WARN_ON(!cycle))
if (!cycle) {
return -EFAULT;

/* Schedule the start time for the beginning of the next

0 comments on commit 274f557

Please sign in to comment.