Skip to content
Permalink
Browse files
uio: pruss: use devm_clk_get() for clk init
This change uses devm_clk_get() to obtain a reference to the clock. It has
the benefit that clk_put() is no longer required, and cleans up the exit &
error path.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
  • Loading branch information
commodo authored and intel-lab-lkp committed Nov 11, 2020
1 parent 74dd4f5 commit 37416440d4299a08c6f1a2dc448f7e9249f303ad
Showing 1 changed file with 3 additions and 6 deletions.
@@ -110,7 +110,6 @@ static void pruss_cleanup(struct device *dev, struct uio_pruss_dev *gdev)
gdev->sram_vaddr,
sram_pool_sz);
clk_disable(gdev->pruss_clk);
clk_put(gdev->pruss_clk);
}

static int pruss_probe(struct platform_device *pdev)
@@ -131,16 +130,16 @@ static int pruss_probe(struct platform_device *pdev)
return -ENOMEM;

/* Power on PRU in case its not done as part of boot-loader */
gdev->pruss_clk = clk_get(dev, "pruss");
gdev->pruss_clk = devm_clk_get(dev, "pruss");
if (IS_ERR(gdev->pruss_clk)) {
dev_err(dev, "Failed to get clock\n");
return PTR_ERR(gdev->pruss_clk);
return ret;
}

ret = clk_enable(gdev->pruss_clk);
if (ret) {
dev_err(dev, "Failed to enable clock\n");
goto err_clk_put;
return ret;
}

regs_prussio = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -229,8 +228,6 @@ static int pruss_probe(struct platform_device *pdev)
gen_pool_free(gdev->sram_pool, gdev->sram_vaddr, sram_pool_sz);
err_clk_disable:
clk_disable(gdev->pruss_clk);
err_clk_put:
clk_put(gdev->pruss_clk);

return ret;
}

0 comments on commit 3741644

Please sign in to comment.