Skip to content
Permalink
Browse files
netfilter: nf_tables: Reject tables of unsupported family
An nftables family is merely a hollow container, its family just a
number and such not reliant on compile-time options other than nftables
support itself. Add an artificial check so attempts at using a family
the kernel can't support fail as early as possible. This helps user
space detect kernels which lack e.g. NFPROTO_INET.

Signed-off-by: Phil Sutter <phil@nwl.cc>
  • Loading branch information
Phil Sutter authored and intel-lab-lkp committed Feb 15, 2022
1 parent c828414 commit 49585d5ef2f413b0bef6e50315e6b6c5bc85e475
Showing 1 changed file with 30 additions and 0 deletions.
@@ -1072,6 +1072,33 @@ static int nft_objname_hash_cmp(struct rhashtable_compare_arg *arg,
return strcmp(obj->key.name, k->name);
}

static bool nft_supported_family(int family)
{
switch (family) {
#ifdef CONFIG_NF_TABLES_INET
case NFPROTO_INET:
#endif
#ifdef CONFIG_NF_TABLES_IPV4
case NFPROTO_IPV4:
#endif
#ifdef CONFIG_NF_TABLES_ARP
case NFPROTO_ARP:
#endif
#ifdef CONFIG_NF_TABLES_NETDEV
case NFPROTO_NETDEV:
#endif
#if IS_ENABLED(CONIFG_NF_TABLES_BRIDGE)
case NFPROTO_BRIDGE:
#endif
#ifdef CONFIG_NF_TABLES_IPV6
case NFPROTO_IPV6:
#endif
return true;
default:
return false;
}
}

static int nf_tables_newtable(struct sk_buff *skb, const struct nfnl_info *info,
const struct nlattr * const nla[])
{
@@ -1086,6 +1113,9 @@ static int nf_tables_newtable(struct sk_buff *skb, const struct nfnl_info *info,
u32 flags = 0;
int err;

if (!nft_supported_family(family))
return -EOPNOTSUPP;

lockdep_assert_held(&nft_net->commit_mutex);
attr = nla[NFTA_TABLE_NAME];
table = nft_table_lookup(net, attr, family, genmask,

0 comments on commit 49585d5

Please sign in to comment.