Skip to content
Permalink
Browse files
ata: Warn about removal of debounce delay in Linux 5.19
The delay is only needed for a few buggy chipsets (PHYs(?)). As 200 ms
is quite a lot in today times, announce the change of the default in
Linux 5.19, and call for tests and reports.
  • Loading branch information
paulmenzel authored and intel-lab-lkp committed Jan 13, 2022
1 parent 81046cd commit 4cc8a654f25f25bd6a46a91a5d1e3e3cfb5d2232
Showing 1 changed file with 5 additions and 1 deletion.
@@ -318,9 +318,13 @@ int sata_link_resume(struct ata_link *link, const unsigned long *params,
* debouncing. Duration can be configured with module
* parameter debounce_delay_ms.
*/
if (!(link->flags & ATA_LFLAG_NO_DEBOUNCE_DELAY))
if (!(link->flags & ATA_LFLAG_NO_DEBOUNCE_DELAY)) {
ata_msleep(link->ap,
(libata_debounce_delay_ms < 0) ? 200 : libata_debounce_delay_ms);
if (libata_debounce_delay_ms < 0)
/* negative values are default */
ata_link_warn(link, "Due to historical reasons a 200 ms delay is applied in sata_link_resume(). Most controllers do not need that, so the default will change to 0 ms in Linux 5.19. Please test with lower values using libata.debounce_delay_ms and report the results <linux-ide@vger.kernel.org>.\n");
}

/* is SControl restored correctly? */
if ((rc = sata_scr_read(link, SCR_CONTROL, &scontrol)))

0 comments on commit 4cc8a65

Please sign in to comment.