Macros with multiple statements should be enclosed in a do - while loop.

Signed-off-by: Fatih YILDIRIM <yildirim.fatih@gmail.com>
0day-ci · Feb 10, 2021 · 68ce21dfbba245eaa3442ad1269237e99aae5d50 · 68ce21d
1 parent 6953026
commit 68ce21dfbba245eaa3442ad1269237e99aae5d50
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
@@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev,		\
 }									\
 static DEVICE_ATTR_RO(name##_avg)
 
-#define gb_loopback_stats_attrs(field)				\
-	gb_loopback_ro_stats_attr(field, min, u);		\
-	gb_loopback_ro_stats_attr(field, max, u);		\
-	gb_loopback_ro_avg_attr(field)
+#define gb_loopback_stats_attrs(field)					\
+	do {								\
+		gb_loopback_ro_stats_attr(field, min, u);		\
+		gb_loopback_ro_stats_attr(field, max, u);		\
+		gb_loopback_ro_avg_attr(field);				\
+	} while (0)
 
 #define gb_loopback_attr(field, type)					\
 static ssize_t field##_show(struct device *dev,				\