From 69022592162daaee87b29588cd562da4439f0517 Mon Sep 17 00:00:00 2001 From: Emmanouil Perselis Date: Mon, 16 Nov 2020 21:43:23 +0100 Subject: [PATCH] Fix warning for static const char * array in audio_manager_module.c On 11/15/20 9:17 AM, Greg Kroah-Hartman wrote: > On Sun, Nov 15, 2020 at 03:53:16PM +0100, Emmanouil Perselis wrote: >> This patch fixes the warning "static const char * array should >> probably be static const char * const" in >> drivers/staging/greybus/audio_manager_module.c >> I think Greg's patch bot is telling you that you need >> to carbon-copy the mailing list on your patch submission, >> not just address it to the maintainers. Added addresses to carbon copy. >> -Alex >> >> Signed-off-by: Emmanouil Perselis >> --- >> drivers/staging/greybus/audio_manager_module.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c >> index 2bfd804183c4..6ef7381f4e85 100644 >> --- a/drivers/staging/greybus/audio_manager_module.c >> +++ b/drivers/staging/greybus/audio_manager_module.c >> @@ -158,7 +158,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module) >> char ip_devices_string[64]; >> char op_devices_string[64]; >> >> - char *envp[] = { >> + static const char * const envp[] = { >> name_string, >> vid_string, >> pid_string, >> -- >> 2.20.1 >> > > Hi, > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > a patch that has triggered this response. He used to manually respond > to these common problems, but in order to save his sanity (he kept > writing the same thing over and over, yet to different people), I was > created. Hopefully you will not take offence and will fix the problem > in your patch and resubmit it so that it can be accepted into the Linux > kernel tree. > > You are receiving this message because of the following common error(s) > as indicated below: > > - Your patch was sent privately to Greg. Kernel development is done in > public, please always cc: a public mailing list with a patch > submission. Using the tool, scripts/get_maintainer.pl on the patch > will tell you what mailing list to cc. > > - You did not specify a description of why the patch is needed, or > possibly, any description at all, in the email body. Please read the > section entitled "The canonical patch format" in the kernel file, > Documentation/SubmittingPatches for what is needed in order to > properly describe the change. > > - You did not write a descriptive Subject: for the patch, allowing Greg, > and everyone else, to know what this patch is all about. Please read > the section entitled "The canonical patch format" in the kernel file, > Documentation/SubmittingPatches for what a proper Subject: line should > look like. > > If you wish to discuss this problem further, or you have questions about > how to resolve this issue, please feel free to respond to this email and > Greg will reply once he has dug out from the pending patches received > from other developers. > > thanks, > > greg k-h's patch email bot > Signed-off-by: Emmanouil Perselis --- drivers/staging/greybus/audio_manager_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 525cf8f8394f25..a5119a2612d858 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -158,7 +158,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module) char ip_devices_string[64]; char op_devices_string[64]; - char *envp[] = { + static const char * const envp[] = { name_string, vid_string, pid_string,