Skip to content

Commit

Permalink
drm/i915/gem: Delay context creation (v2)
Browse files Browse the repository at this point in the history 
The current context uAPI allows for two methods of setting context
parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM.  The
former is allowed to be called at any time while the later happens as
part of GEM_CONTEXT_CREATE.  Currently, everything settable via one is
settable via the other.  While some params are fairly simple and setting
them on a live context is harmless such as the context priority, others
are far trickier such as the VM or the set of engines.  In order to swap
out the VM, for instance, we have to delay until all current in-flight
work is complete, swap in the new VM, and then continue.  This leads to
a plethora of potential race conditions we'd really rather avoid.

In previous patches, we added a i915_gem_proto_context struct which is
capable of storing and tracking all such create parameters.  This commit
delays the creation of the actual context until after the client is done
configuring it with SET_CONTEXT_PARAM.  From the perspective of the
client, it has the same u32 context ID the whole time.  From the
perspective of i915, however, it's an i915_gem_proto_context right up
until the point where we attempt to do something which the proto-context
can't handle.  Then the real context gets created.

This is accomplished via a little xarray dance.  When GEM_CONTEXT_CREATE
is called, we create a proto-context, reserve a slot in context_xa but
leave it NULL, the proto-context in the corresponding slot in
proto_context_xa.  Then, whenever we go to look up a context, we first
check context_xa.  If it's there, we return the i915_gem_context and
we're done.  If it's not, we look in proto_context_xa and, if we find it
there, we create the actual context and kill the proto-context.

In order for this dance to work properly, everything which ever touches
a proto-context is guarded by drm_i915_file_private::proto_context_lock,
including context creation.  Yes, this means context creation now takes
a giant global lock but it can't really be helped and that should never
be on any driver's fast-path anyway.

v2 (Daniel Vetter):
 - Commit message grammatical fixes.
 - Use WARN_ON instead of GEM_BUG_ON
 - Rename lazy_create_context_locked to finalize_create_context_locked
 - Rework the control-flow logic in the setparam ioctl
 - Better documentation all around

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
@gfxstrand @intel-lab-lkp
gfxstrand authored and intel-lab-lkp committed Jun 9, 2021
1 parent bf250a5 commit 7e9cc28
Show file tree
Hide file tree
Showing 5 changed files with 283 additions and 58 deletions.
203 changes: 160 additions & 43 deletions drivers/gpu/drm/i915/gem/i915_gem_context.c
View file
Expand Up @@ -278,6 +278,42 @@ proto_context_create(struct drm_i915_private *i915, unsigned int flags)
return err;
}

static int proto_context_register_locked(struct drm_i915_file_private *fpriv,
struct i915_gem_proto_context *pc,
u32 *id)
{
int ret;
void *old;

lockdep_assert_held(&fpriv->proto_context_lock);

ret = xa_alloc(&fpriv->context_xa, id, NULL, xa_limit_32b, GFP_KERNEL);
if (ret)
return ret;

old = xa_store(&fpriv->proto_context_xa, *id, pc, GFP_KERNEL);
if (xa_is_err(old)) {
xa_erase(&fpriv->context_xa, *id);
return xa_err(old);
}
WARN_ON(old);

return 0;
}

static int proto_context_register(struct drm_i915_file_private *fpriv,
struct i915_gem_proto_context *pc,
u32 *id)
{
int ret;

mutex_lock(&fpriv->proto_context_lock);
ret = proto_context_register_locked(fpriv, pc, id);
mutex_unlock(&fpriv->proto_context_lock);

return ret;
}

static int set_proto_ctx_vm(struct drm_i915_file_private *fpriv,
struct i915_gem_proto_context *pc,
const struct drm_i915_gem_context_param *args)
Expand Down Expand Up @@ -1448,12 +1484,12 @@ void i915_gem_init__contexts(struct drm_i915_private *i915)
init_contexts(&i915->gem.contexts);
}

static int gem_context_register(struct i915_gem_context *ctx,
struct drm_i915_file_private *fpriv,
u32 *id)
static void gem_context_register(struct i915_gem_context *ctx,
struct drm_i915_file_private *fpriv,
u32 id)
{
struct drm_i915_private *i915 = ctx->i915;
int ret;
void *old;

ctx->file_priv = fpriv;

Expand All @@ -1462,19 +1498,12 @@ static int gem_context_register(struct i915_gem_context *ctx,
current->comm, pid_nr(ctx->pid));

/* And finally expose ourselves to userspace via the idr */
ret = xa_alloc(&fpriv->context_xa, id, ctx, xa_limit_32b, GFP_KERNEL);
if (ret)
goto err_pid;
old = xa_store(&fpriv->context_xa, id, ctx, GFP_KERNEL);
WARN_ON(old);

spin_lock(&i915->gem.contexts.lock);
list_add_tail(&ctx->link, &i915->gem.contexts.list);
spin_unlock(&i915->gem.contexts.lock);

return 0;

err_pid:
put_pid(fetch_and_zero(&ctx->pid));
return ret;
}

int i915_gem_context_open(struct drm_i915_private *i915,
Expand All @@ -1484,9 +1513,12 @@ int i915_gem_context_open(struct drm_i915_private *i915,
struct i915_gem_proto_context *pc;
struct i915_gem_context *ctx;
int err;
u32 id;

xa_init_flags(&file_priv->context_xa, XA_FLAGS_ALLOC);
mutex_init(&file_priv->proto_context_lock);
xa_init_flags(&file_priv->proto_context_xa, XA_FLAGS_ALLOC);

/* 0 reserved for the default context */
xa_init_flags(&file_priv->context_xa, XA_FLAGS_ALLOC1);

/* 0 reserved for invalid/unassigned ppgtt */
xa_init_flags(&file_priv->vm_xa, XA_FLAGS_ALLOC1);
Expand All @@ -1504,28 +1536,31 @@ int i915_gem_context_open(struct drm_i915_private *i915,
goto err;
}

err = gem_context_register(ctx, file_priv, &id);
if (err < 0)
goto err_ctx;
gem_context_register(ctx, file_priv, 0);

GEM_BUG_ON(id);
return 0;

err_ctx:
context_close(ctx);
err:
xa_destroy(&file_priv->vm_xa);
xa_destroy(&file_priv->context_xa);
xa_destroy(&file_priv->proto_context_xa);
mutex_destroy(&file_priv->proto_context_lock);
return err;
}

void i915_gem_context_close(struct drm_file *file)
{
struct drm_i915_file_private *file_priv = file->driver_priv;
struct i915_gem_proto_context *pc;
struct i915_address_space *vm;
struct i915_gem_context *ctx;
unsigned long idx;

xa_for_each(&file_priv->proto_context_xa, idx, pc)
proto_context_close(pc);
xa_destroy(&file_priv->proto_context_xa);
mutex_destroy(&file_priv->proto_context_lock);

xa_for_each(&file_priv->context_xa, idx, ctx)
context_close(ctx);
xa_destroy(&file_priv->context_xa);
Expand Down Expand Up @@ -2480,12 +2515,73 @@ static bool client_is_banned(struct drm_i915_file_private *file_priv)
return atomic_read(&file_priv->ban_score) >= I915_CLIENT_SCORE_BANNED;
}

static inline struct i915_gem_context *
__context_lookup(struct drm_i915_file_private *file_priv, u32 id)
{
struct i915_gem_context *ctx;

rcu_read_lock();
ctx = xa_load(&file_priv->context_xa, id);
if (ctx && !kref_get_unless_zero(&ctx->ref))
ctx = NULL;
rcu_read_unlock();

return ctx;
}

struct i915_gem_context *
finalize_create_context_locked(struct drm_i915_file_private *file_priv,
struct i915_gem_proto_context *pc, u32 id)
{
struct i915_gem_context *ctx;
void *old;

lockdep_assert_held(&file_priv->proto_context_lock);

ctx = i915_gem_create_context(file_priv->dev_priv, pc);
if (IS_ERR(ctx))
return ctx;

gem_context_register(ctx, file_priv, id);

old = xa_erase(&file_priv->proto_context_xa, id);
GEM_BUG_ON(old != pc);
proto_context_close(pc);

/* One for the xarray and one for the caller */
return i915_gem_context_get(ctx);
}

struct i915_gem_context *
i915_gem_context_lookup(struct drm_i915_file_private *file_priv, u32 id)
{
struct i915_gem_proto_context *pc;
struct i915_gem_context *ctx;

ctx = __context_lookup(file_priv, id);
if (ctx)
return ctx;

mutex_lock(&file_priv->proto_context_lock);
/* Try one more time under the lock */
ctx = __context_lookup(file_priv, id);
if (!ctx) {
pc = xa_load(&file_priv->proto_context_xa, id);
if (!pc)
ctx = ERR_PTR(-ENOENT);
else
ctx = finalize_create_context_locked(file_priv, pc, id);
}
mutex_unlock(&file_priv->proto_context_lock);

return ctx;
}

int i915_gem_context_create_ioctl(struct drm_device *dev, void *data,
struct drm_file *file)
{
struct drm_i915_private *i915 = to_i915(dev);
struct drm_i915_gem_context_create_ext *args = data;
struct i915_gem_context *ctx;
struct create_ext ext_data;
int ret;
u32 id;
Expand Down Expand Up @@ -2517,28 +2613,21 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data,
create_extensions,
ARRAY_SIZE(create_extensions),
&ext_data);
if (ret) {
proto_context_close(ext_data.pc);
return ret;
}
if (ret)
goto err_pc;
}

ctx = i915_gem_create_context(i915, ext_data.pc);
proto_context_close(ext_data.pc);
if (IS_ERR(ctx))
return PTR_ERR(ctx);

ret = gem_context_register(ctx, ext_data.fpriv, &id);
ret = proto_context_register(ext_data.fpriv, ext_data.pc, &id);
if (ret < 0)
goto err_ctx;
goto err_pc;

args->ctx_id = id;
drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id);

return 0;

err_ctx:
context_close(ctx);
err_pc:
proto_context_close(ext_data.pc);
return ret;
}

Expand All @@ -2547,6 +2636,7 @@ int i915_gem_context_destroy_ioctl(struct drm_device *dev, void *data,
{
struct drm_i915_gem_context_destroy *args = data;
struct drm_i915_file_private *file_priv = file->driver_priv;
struct i915_gem_proto_context *pc;
struct i915_gem_context *ctx;

if (args->pad != 0)
Expand All @@ -2555,11 +2645,24 @@ int i915_gem_context_destroy_ioctl(struct drm_device *dev, void *data,
if (!args->ctx_id)
return -ENOENT;

/* We need to hold the proto-context lock here to prevent races
* with finalize_create_context_locked().
*/
mutex_lock(&file_priv->proto_context_lock);
ctx = xa_erase(&file_priv->context_xa, args->ctx_id);
if (!ctx)
pc = xa_erase(&file_priv->proto_context_xa, args->ctx_id);
mutex_unlock(&file_priv->proto_context_lock);

if (!ctx && !pc)
return -ENOENT;
GEM_WARN_ON(ctx && pc);

if (pc)
proto_context_close(pc);

if (ctx)
context_close(ctx);

context_close(ctx);
return 0;
}

Expand Down Expand Up @@ -2692,16 +2795,30 @@ int i915_gem_context_setparam_ioctl(struct drm_device *dev, void *data,
{
struct drm_i915_file_private *file_priv = file->driver_priv;
struct drm_i915_gem_context_param *args = data;
struct i915_gem_proto_context *pc;
struct i915_gem_context *ctx;
int ret;
int ret = 0;

ctx = i915_gem_context_lookup(file_priv, args->ctx_id);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
mutex_lock(&file_priv->proto_context_lock);
ctx = __context_lookup(file_priv, args->ctx_id);
if (!ctx) {
/* FIXME: We should consider disallowing SET_CONTEXT_PARAM
* for most things on future platforms. Clients should be
* using CONTEXT_CREATE_EXT_PARAM instead.
*/
pc = xa_load(&file_priv->proto_context_xa, args->ctx_id);
if (pc)
ret = set_proto_ctx_param(file_priv, pc, args);
else
ret = -ENOENT;
}
mutex_unlock(&file_priv->proto_context_lock);

ret = ctx_setparam(file_priv, ctx, args);
if (ctx) {
ret = ctx_setparam(file_priv, ctx, args);
i915_gem_context_put(ctx);
}

i915_gem_context_put(ctx);
return ret;
}

Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/gem/i915_gem_context.h
View file
Expand Up @@ -133,6 +133,9 @@ int i915_gem_context_setparam_ioctl(struct drm_device *dev, void *data,
int i915_gem_context_reset_stats_ioctl(struct drm_device *dev, void *data,
struct drm_file *file);

struct i915_gem_context *
i915_gem_context_lookup(struct drm_i915_file_private *file_priv, u32 id);

static inline struct i915_gem_context *
i915_gem_context_get(struct i915_gem_context *ctx)
{
Expand Down
54 changes: 54 additions & 0 deletions drivers/gpu/drm/i915/gem/i915_gem_context_types.h
View file
Expand Up @@ -122,6 +122,60 @@ struct i915_gem_proto_engine {
* a struct i915_gem_context. This is used to gather parameters provided
* either through creation flags or via SET_CONTEXT_PARAM so that, when we
* create the final i915_gem_context, those parameters can be immutable.
*
* The context uAPI allows for two methods of setting context parameters:
* SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The former is
* allowed to be called at any time while the later happens as part of
* GEM_CONTEXT_CREATE. When these were initially added, Currently,
* everything settable via one is settable via the other. While some
* params are fairly simple and setting them on a live context is harmless
* such the context priority, others are far trickier such as the VM or the
* set of engines. To avoid some truly nasty race conditions, we don't
* allow setting the VM or the set of engines on live contexts.
*
* The way we dealt with this without breaking older userspace that sets
* the VM or engine set via SET_CONTEXT_PARAM is to delay the creation of
* the actual context until after the client is done configuring it with
* SET_CONTEXT_PARAM. From the perspective of the client, it has the same
* u32 context ID the whole time. From the perspective of i915, however,
* it's an i915_gem_proto_context right up until the point where we attempt
* to do something which the proto-context can't handle at which point the
* real context gets created.
*
* This is accomplished via a little xarray dance. When GEM_CONTEXT_CREATE
* is called, we create a proto-context, reserve a slot in context_xa but
* leave it NULL, the proto-context in the corresponding slot in
* proto_context_xa. Then, whenever we go to look up a context, we first
* check context_xa. If it's there, we return the i915_gem_context and
* we're done. If it's not, we look in proto_context_xa and, if we find it
* there, we create the actual context and kill the proto-context.
*
* At the time we made this change (April, 2021), we did a fairly complete
* audit of existing userspace to ensure this wouldn't break anything:
*
* - Mesa/i965 didn't use the engines or VM APIs at all
*
* - Mesa/ANV used the engines API but via CONTEXT_CREATE_EXT_SETPARAM and
* didn't use the VM API.
*
* - Mesa/iris didn't use the engines or VM APIs at all
*
* - The open-source compute-runtime didn't yet use the engines API but
* did use the VM API via SET_CONTEXT_PARAM. However, CONTEXT_SETPARAM
* was always the second ioctl on that context, immediately following
* GEM_CONTEXT_CREATE.
*
* - The media driver sets engines and bonding/balancing via
* SET_CONTEXT_PARAM. However, CONTEXT_SETPARAM to set the VM was
* always the second ioctl on that context, immediately following
* GEM_CONTEXT_CREATE and setting engines immediately followed that.
*
* In order for this dance to work properly, any modification to an
* i915_gem_proto_context that is exposed to the client via
* drm_i915_file_private::proto_context_xa must be guarded by
* drm_i915_file_private::proto_context_lock. The exception is when a
* proto-context has not yet been exposed such as when handling
* CONTEXT_CREATE_SET_PARAM during GEM_CONTEXT_CREATE.
*/
struct i915_gem_proto_context {
/** @vm: See &i915_gem_context.vm */
Expand Down

0 comments on commit 7e9cc28

Please sign in to comment.