Skip to content
Permalink
Browse files
rndis_wlan: Make use of cpu_to_le16_array()
Since we have a new helper, let's replace open coded variant by it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jussi Kivilinna <jussi.kivilinna@iki.fi>
Cc: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
andy-shev authored and intel-lab-lkp committed Aug 17, 2020
1 parent 0aaf48f commit 9ad6b9bbb11c203d62f21fbf7101b8c04aaea958
Showing 1 changed file with 6 additions and 5 deletions.
@@ -859,9 +859,12 @@ static int rndis_set_config_parameter(struct usbnet *dev, char *param,
int value_type, void *value)
{
struct ndis_config_param *infobuf;
int value_len, info_len, param_len, ret, i;
int value_len, info_len, param_len, ret;
__le16 *unibuf;
__le32 *dst_value;
#ifdef DEBUG
int i;
#endif

if (value_type == 0)
value_len = sizeof(__le32);
@@ -901,13 +904,11 @@ static int rndis_set_config_parameter(struct usbnet *dev, char *param,

/* simple string to unicode string conversion */
unibuf = (void *)infobuf + sizeof(*infobuf);
for (i = 0; i < param_len / sizeof(__le16); i++)
unibuf[i] = cpu_to_le16(param[i]);
cpu_to_le16_array(unibuf, param, param_len / sizeof(__le16));

if (value_type == 2) {
unibuf = (void *)infobuf + sizeof(*infobuf) + param_len;
for (i = 0; i < value_len / sizeof(__le16); i++)
unibuf[i] = cpu_to_le16(((u8 *)value)[i]);
cpu_to_le16_array(unibuf, value, value_len / sizeof(__le16));
} else {
dst_value = (void *)infobuf + sizeof(*infobuf) + param_len;
*dst_value = cpu_to_le32(*(u32 *)value);

0 comments on commit 9ad6b9b

Please sign in to comment.