Skip to content

Commit

Permalink
thermal: ti-soc-thermal: Enable addition power management
Browse files Browse the repository at this point in the history
The bandgap sensor can be idled when the processor is too, but it
isn't currently being done, so the power consumption of OMAP3
boards can elevated if the bangap sensor is enabled.

This patch attempts to use some additional power management
to idle the clock to the bandgap when not needed.

Signed-off-by: Adam Ford <aford173@gmail.com>
  • Loading branch information
aford173 authored and intel-lab-lkp committed Aug 18, 2020
1 parent cf96fbf commit ad9a82e
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 1 deletion.
47 changes: 46 additions & 1 deletion drivers/thermal/ti-soc-thermal/ti-bandgap.c
Expand Up @@ -25,10 +25,18 @@
#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/io.h>
#include <linux/cpu_pm.h>
#include <linux/device.h>
#include <linux/pm_runtime.h>
#include <linux/pm.h>
#include <linux/of.h>
#include <linux/of_device.h>

#include "ti-bandgap.h"

static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id);
static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
unsigned long cmd, void *v);

/*** Helper functions to access registers and their bitfields ***/

Expand Down Expand Up @@ -1008,6 +1016,9 @@ int ti_bandgap_probe(struct platform_device *pdev)
}
}

bgp->nb.notifier_call = bandgap_omap_cpu_notifier;
cpu_pm_register_notifier(&bgp->nb);

return 0;

remove_last_cooling:
Expand Down Expand Up @@ -1041,7 +1052,9 @@ int ti_bandgap_remove(struct platform_device *pdev)
struct ti_bandgap *bgp = platform_get_drvdata(pdev);
int i;

/* First thing is to remove sensor interfaces */
cpu_pm_unregister_notifier(&bgp->nb);

/* Remove sensor interfaces */
for (i = 0; i < bgp->conf->sensor_count; i++) {
if (bgp->conf->sensors[i].unregister_cooling)
bgp->conf->sensors[i].unregister_cooling(bgp, i);
Expand Down Expand Up @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev)
return err;
}

static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
unsigned long cmd, void *v)
{
struct ti_bandgap *bgp;

bgp = container_of(nb, struct ti_bandgap, nb);

spin_lock(&bgp->lock);
switch (cmd) {
case CPU_CLUSTER_PM_ENTER:
if (bgp->is_suspended)
break;
ti_bandgap_save_ctxt(bgp);
ti_bandgap_power(bgp, false);
if (TI_BANDGAP_HAS(bgp, CLK_CTRL))
clk_disable(bgp->fclock);
break;
case CPU_CLUSTER_PM_ENTER_FAILED:
case CPU_CLUSTER_PM_EXIT:
if (bgp->is_suspended)
break;
if (TI_BANDGAP_HAS(bgp, CLK_CTRL))
clk_enable(bgp->fclock);
ti_bandgap_power(bgp, true);
ti_bandgap_restore_ctxt(bgp);
break;
}
spin_unlock(&bgp->lock);

return NOTIFY_OK;
}

static int ti_bandgap_resume(struct device *dev)
{
struct ti_bandgap *bgp = dev_get_drvdata(dev);
Expand Down
6 changes: 6 additions & 0 deletions drivers/thermal/ti-soc-thermal/ti-bandgap.h
Expand Up @@ -12,6 +12,10 @@
#include <linux/spinlock.h>
#include <linux/types.h>
#include <linux/err.h>
#include <linux/cpu_pm.h>
#include <linux/device.h>
#include <linux/pm_runtime.h>
#include <linux/pm.h>

struct gpio_desc;

Expand Down Expand Up @@ -203,6 +207,8 @@ struct ti_bandgap {
int irq;
struct gpio_desc *tshut_gpiod;
u32 clk_rate;
struct notifier_block nb;
unsigned int is_suspended:1;
};

/**
Expand Down

0 comments on commit ad9a82e

Please sign in to comment.