Skip to content
Permalink
Browse files
ipv6: check return value of ipv6_skip_exthdr
The offset value is used in pointer math on skb->data.
Since ipv6_skip_exthdr may return -1 the pointer to uh and th
may not point to the actual udp and tcp headers and potentially
overwrite other stuff. This is why I think this should be checked.

Signed-off-by: Jordy Zomer <jordy@pwning.systems>
  • Loading branch information
JordyZomer authored and intel-lab-lkp committed Nov 17, 2021
1 parent 93ec132 commit afe093a81395e12df66d6b2145bcb98d4fc67b55
Showing 1 changed file with 5 additions and 0 deletions.
@@ -808,6 +808,11 @@ int esp6_input_done2(struct sk_buff *skb, int err)
struct tcphdr *th;

offset = ipv6_skip_exthdr(skb, offset, &nexthdr, &frag_off);

if (offset < 0)
err = -EINVAL;
goto out;

uh = (void *)(skb->data + offset);
th = (void *)(skb->data + offset);
hdr_len += offset;

0 comments on commit afe093a

Please sign in to comment.