Skip to content
Permalink
Browse files
input: da7280: Make use of the helper function dev_err_probe()
devm_pwm_get() can return -EPROBE_DEFER if the pwm regulator is not
ready yet. Use dev_err_probe() for pwm regulator resources
to indicate the deferral reason when waiting for the
resource to come up.

Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
  • Loading branch information
zhaoxiao authored and intel-lab-lkp committed Feb 16, 2022
1 parent 0c0ef67 commit b2755b400194965e54d346dd316d62002ce8cde3
Showing 1 changed file with 3 additions and 6 deletions.
@@ -1165,12 +1165,9 @@ static int da7280_probe(struct i2c_client *client,

if (haptics->const_op_mode == DA7280_PWM_MODE) {
haptics->pwm_dev = devm_pwm_get(dev, NULL);
error = PTR_ERR_OR_ZERO(haptics->pwm_dev);
if (error) {
if (error != -EPROBE_DEFER)
dev_err(dev, "Unable to request PWM: %d\n",
error);
return error;
if (IS_ERR(haptics->pwm_dev))
return dev_err_probe(dev, PTR_ERR(haptics->pwm_dev),
"Unable to request PWM\n");
}

/* Sync up PWM state and ensure it is off. */

0 comments on commit b2755b4

Please sign in to comment.