Skip to content
Permalink
Haren-Myneni/E…
Switch branches/tags

Commits on Apr 11, 2021

  1. crypto/nx: sysfs interface to export NX capabilities

    Changes to export the following NXGZIP capabilities through sysfs:
    
    /sys/devices/vio/ibm,compression-v1/NxGzCaps:
    min_compress_len  /*Recommended minimum compress length in bytes*/
    min_decompress_len /*Recommended minimum decompress length in bytes*/
    req_max_processed_len /* Maximum number of bytes processed in one
    			request */
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  2. crypto/nx: Get NX capabilities for GZIP coprocessor type

    phyp provides NX capabilities which gives recommended minimum
    compression / decompression length and maximum request buffer size
    in bytes.
    
    Changes to get NX overall capabilities which points to the specific
    features phyp supports. Then retrieve NXGZIP specific capabilities.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  3. crypto/nx: Register and unregister VAS interface

    Changes to create /dev/crypto/nx-gzip interface with VAS register
    and to remove this interface with VAS unregister.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  4. crypto/nx: Rename nx-842-pseries file name to nx-common-pseries

    Rename nx-842-pseries.c to nx-common-pseries.c to add code for new
    GZIP compression type. The actual functionality is not changed in
    this patch.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  5. powerpc/pseries/vas: sysfs interface to export capabilities

    pHyp provides GZIP default and GZIP QoS capabilities which gives
    the total number of credits are available in LPAR. This patch
    creates sysfs entries and exports LPAR credits, the currently used
    and the available credits for each feature.
    
    /sys/kernel/vas/VasCaps/VDefGzip: (default GZIP capabilities)
    	avail_lpar_creds /* Available credits to use */
    	target_lpar_creds /* Total credits available which can be
    			 /* changed with DLPAR operation */
    	used_lpar_creds  /* Used credits */
    
    /sys/kernel/vas/VasCaps/VQosGzip (QoS GZIP capabilities)
    	avail_lpar_creds
    	target_lpar_creds
    	used_lpar_creds
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  6. powerpc/pseries/vas: Setup IRQ and fault handling

    When NX sees a fault on the user space buffer, generates a fault
    interrupt and pHyp forwards that interrupt to OS. Then the kernel
    makes H_GET_NX_FAULT HCALL to retrieve the fault CRB information.
    
    This patch adds changes to setup IRQ per each window and handles
    fault by updating CSB.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  7. powerpc/pseries/vas: Integrate API with open/close windows

    This patch adds VAS window allocatioa/close with the corresponding
    HCALLs. Also changes to integrate with the existing user space VAS
    API and provide register/unregister functions to NX pseries driver.
    
    The driver register function is used to create the user space
    interface (/dev/crypto/nx-gzip) and unregister to remove this entry.
    
    The user space process opens this device node and makes an ioctl
    to allocate VAS window. The close interface is used to deallocate
    window.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  8. powerpc/pseries/vas: Implement to get all capabilities

    pHyp provides various VAS capabilities such as GZIP default and QoS
    capabilities which are used to determine total number of credits
    available in LPAR, maximum window credits, maximum LPAR credits,
    whether usermode copy/paste is supported, and etc.
    
    So first retrieve overall vas capabilities using
    H_QUERY_VAS_CAPABILITIES HCALL which tells the specific features that
    are available. Then retrieve the specific capabilities by using the
    feature type in H_QUERY_VAS_CAPABILITIES HCALL.
    
    pHyp supports only GZIP default and GZIP QoS capabilities right now.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  9. powerpc/pseries/VAS: Implement allocate/modify/deallocate HCALLS

    This patch adds the following HCALLs which are used to allocate,
    modify and deallocate VAS windows.
    
    H_ALLOCATE_VAS_WINDOW: Allocate VAS window
    H_DEALLOCATE_VAS_WINDOW: Close VAS window
    H_MODIFY_VAS_WINDOW: Setup window before using
    
    Also adds phyp call (H_QUERY_VAS_CAPABILITIES) to get all VAS
    capabilities that phyp provides.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  10. powerpc/vas: Define QoS credit flag to allocate window

    pHyp introduces two different type of credits: Default and Quality
    of service (QoS).
    
    The total number of default credits available on each LPAR depends
    on CPU resources configured. But these credits can be shared or
    over-committed across LPARs in shared mode which can result in
    paste command failure (RMA_busy). To avoid NX HW contention, phyp
    introduces QoS credit type which makes sure guaranteed access to NX
    resources. The system admins can assign QoS credits for each LPAR
    via HMC.
    
    Default credit type is used to allocate a VAS window by default as
    on powerVM implementation. But the process can pass VAS_WIN_QOS_CREDITS
    flag with VAS_TX_WIN_OPEN ioctl to open VAS QoS type window.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  11. powerpc/pseries/vas: Define VAS/NXGZIP HCALLs and structs

    This patch adds HCALLs and other definitions. Also define structs
    that are used in VAS implementation on powerVM.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  12. powerpc/vas: Define and use common vas_window struct

    Same vas_window struct is used on powerNV and pseries. So this patch
    changes in struct vas_window to support both platforms and also the
    corresponding modifications in powerNV vas code.
    
    On powerNV vas_window is used for both TX and RX windows, whereas
    only for TX windows on powerVM. So some elements are specific to
    these platforms.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  13. powerpc/vas: Move update_csb/dump_crb to platform independent

    NX issues an interrupt when sees fault on user space buffer. The
    kernel processes the fault by updating CSB. This functionality is
    same for both powerNV and pseries. So this patch moves these
    functions to vas-api.c and the actual functionality is not changed.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  14. powerpc/vas: Create take/drop task reference functions

    Take task reference when each window opens and drops during close.
    This functionality is needed for powerNV and pseries. So this patch
    defines the existing code as functions in powerpc platform
    independent vas-api.c
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  15. powerpc/vas: Make VAS API powerpc platform independent

    Using the same /dev/crypto/nx-gzip interface for both powerNV and
    pseries. So this patcb moves VAS API to powerpc platform indepedent
    directory. The actual functionality is not changed in this patch.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021
  16. powerpc/powernv/vas: Rename register/unregister functions

    powerNV and pseries drivers register / unregister to the corresponding
    VAS code separately. So rename powerNV VAS API register/unregister
    functions.
    
    Signed-off-by: Haren Myneni <haren@linux.ibm.com>
    Haren Myneni authored and intel-lab-lkp committed Apr 11, 2021

Commits on Apr 8, 2021

  1. powerpc/32: Remove powerpc specific definition of 'ptrdiff_t'

    For unknown reason, old commit d27dfd388715 ("Import pre2.0.8")
    changed 'ptrdiff_t' from 'int' to 'long'.
    
    GCC expects it as 'int' really, and this leads to the following
    warning when building KFENCE:
    
      CC      mm/kfence/report.o
    In file included from ./include/linux/printk.h:7,
                     from ./include/linux/kernel.h:16,
                     from mm/kfence/report.c:10:
    mm/kfence/report.c: In function 'kfence_report_error':
    ./include/linux/kern_levels.h:5:18: warning: format '%td' expects argument of type 'ptrdiff_t', but argument 6 has type 'long int' [-Wformat=]
        5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
          |                  ^~~~~~
    ./include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
       11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
          |                  ^~~~~~~~
    ./include/linux/printk.h:343:9: note: in expansion of macro 'KERN_ERR'
      343 |  printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
          |         ^~~~~~~~
    mm/kfence/report.c:213:3: note: in expansion of macro 'pr_err'
      213 |   pr_err("Out-of-bounds %s at 0x%p (%luB %s of kfence-#%td):\n",
          |   ^~~~~~
    
    <asm-generic/uapi/posix-types.h> defines it as 'int', and
    defines 'size_t' and 'ssize_t' exactly as powerpc do, so
    remove the powerpc specific definitions and fallback on
    generic ones.
    
    Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/e43d133bf52fa19e577f64f3a3a38cedc570377d.1617616601.git.christophe.leroy@csgroup.eu
    chleroy authored and mpe committed Apr 8, 2021
  2. powerpc: iommu: fix build when neither PCI or IBMVIO is set

    When neither CONFIG_PCI nor CONFIG_IBMVIO is set/enabled, iommu.c has a
    build error. The fault injection code is not useful in that kernel config,
    so make the FAIL_IOMMU option depend on PCI || IBMVIO.
    
    Prevents this build error (warning escalated to error):
    ../arch/powerpc/kernel/iommu.c:178:30: error: 'fail_iommu_bus_notifier' defined but not used [-Werror=unused-variable]
      178 | static struct notifier_block fail_iommu_bus_notifier = {
    
    Fixes: d6b9a81 ("powerpc: IOMMU fault injection")
    Reported-by: kernel test robot <lkp@intel.com>
    Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210404192623.10697-1-rdunlap@infradead.org
    rddunlap authored and mpe committed Apr 8, 2021
  3. powerpc/pseries: remove unneeded semicolon

    Eliminate the following coccicheck warning:
    ./arch/powerpc/platforms/pseries/lpar.c:1633:2-3: Unneeded semicolon
    
    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1617672785-81372-1-git-send-email-yang.lee@linux.alibaba.com
    Yang Li authored and mpe committed Apr 8, 2021
  4. powerpc/64s: power4 nap fixup in C

    There is no need for this to be in asm, use the new intrrupt entry wrapper.
    
    Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
    Tested-by: Andreas Schwab <schwab@linux-m68k.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210406025508.821718-1-npiggin@gmail.com
    npiggin authored and mpe committed Apr 8, 2021
  5. powerpc/perf: Fix PMU constraint check for EBB events

    The power PMU group constraints includes check for EBB events to make
    sure all events in a group must agree on EBB. This will prevent
    scheduling EBB and non-EBB events together. But in the existing check,
    settings for constraint mask and value is interchanged. Patch fixes the
    same.
    
    Before the patch, PMU selftest "cpu_event_pinned_vs_ebb_test" fails with
    below in dmesg logs. This happens because EBB event gets enabled along
    with a non-EBB cpu event.
    
      [35600.453346] cpu_event_pinne[41326]: illegal instruction (4)
      at 10004a18 nip 10004a18 lr 100049f8 code 1 in
      cpu_event_pinned_vs_ebb_test[10000000+10000]
    
    Test results after the patch:
    
      $ ./pmu/ebb/cpu_event_pinned_vs_ebb_test
      test: cpu_event_pinned_vs_ebb
      tags: git_version:v5.12-rc5-93-gf28c3125acd3-dirty
      Binding to cpu 8
      EBB Handler is at 0x100050c8
      read error on event 0x7fffe6bd4040!
      PM_RUN_INST_CMPL: result 9872 running/enabled 37930432
      success: cpu_event_pinned_vs_ebb
    
    This bug was hidden by other logic until commit 1908dc9 (perf:
    Tweak perf_event_attr::exclusive semantics).
    
    Fixes: 4df4899 ("powerpc/perf: Add power8 EBB support")
    Reported-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
    Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    [mpe: Mention commit 1908dc9]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1617725761-1464-1-git-send-email-atrajeev@linux.vnet.ibm.com
    athira-rajeev authored and mpe committed Apr 8, 2021
  6. selftests/powerpc: Suggest memtrace instead of /dev/mem for ci memory

    The suggested alternative for getting cache-inhibited memory with 'mem='
    and /dev/mem is pretty hacky. Also, PAPR guests do not allow system
    memory to be mapped cache-inhibited so despite /dev/mem being available
    this will not work which can cause confusion.  Instead recommend using
    the memtrace buffers. memtrace is only available on powernv so there
    will not be any chance of trying to do this in a guest.
    
    Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210225032108.1458352-2-jniethe5@gmail.com
    iamjpn authored and mpe committed Apr 8, 2021
  7. powerpc/powernv/memtrace: Allow mmaping trace buffers

    Let the memory removed from the linear mapping to be used for the trace
    buffers be mmaped. This is a useful way of providing cache-inhibited
    memory for the alignment_handler selftest.
    
    Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
    [mpe: make memtrace_mmap() static as noticed by lkp@intel.com]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210225032108.1458352-1-jniethe5@gmail.com
    iamjpn authored and mpe committed Apr 8, 2021
  8. powerpc/kexec: Don't use .machine ppc64 in trampoline_64.S

    As best as I can tell the ".machine" directive in trampoline_64.S is no
    longer, or never was, necessary.
    
    It was added in commit 0d97631 ("powerpc: Add purgatory for
    kexec_file_load() implementation."), which created the file based on
    the kexec-tools purgatory. It may be/have-been necessary in the
    kexec-tools version, but we have a completely different build system,
    and we already pass the desired CPU flags, eg:
    
      gcc ... -m64 -Wl,-a64 -mabi=elfv2 -Wa,-maltivec -Wa,-mpower4 -Wa,-many
      ... arch/powerpc/purgatory/trampoline_64.S
    
    So drop the ".machine" directive and rely on the assembler flags.
    
    Reported-by: Daniel Axtens <dja@axtens.net>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
    Link: https://lore.kernel.org/r/20210315034159.315675-1-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  9. powerpc/64: Move security code into security.c

    When the original spectre/meltdown mitigations were merged we put them
    in setup_64.c for lack of a better place.
    
    Since then we created security.c for some of the other mitigation
    related code. But it should all be in there.
    
    This sort of code movement can cause trouble for backports, but
    hopefully this code is relatively stable these days (famous last words).
    
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210326101201.1973552-1-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  10. powerpc/mm/64s: Allow STRICT_KERNEL_RWX again

    We have now fixed the known bugs in STRICT_KERNEL_RWX for Book3S
    64-bit Hash and Radix MMUs, see preceding commits, so allow the
    option to be selected again.
    
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210331003845.216246-6-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  11. powerpc/mm/64s/hash: Add real-mode change_memory_range() for hash LPAR

    When we enabled STRICT_KERNEL_RWX we received some reports of boot
    failures when using the Hash MMU and running under phyp. The crashes
    are intermittent, and often exhibit as a completely unresponsive
    system, or possibly an oops.
    
    One example, which was caught in xmon:
    
      [   14.068327][    T1] devtmpfs: mounted
      [   14.069302][    T1] Freeing unused kernel memory: 5568K
      [   14.142060][  T347] BUG: Unable to handle kernel instruction fetch
      [   14.142063][    T1] Run /sbin/init as init process
      [   14.142074][  T347] Faulting instruction address: 0xc000000000004400
      cpu 0x2: Vector: 400 (Instruction Access) at [c00000000c7475e0]
          pc: c000000000004400: exc_virt_0x4400_instruction_access+0x0/0x80
          lr: c0000000001862d4: update_rq_clock+0x44/0x110
          sp: c00000000c747880
         msr: 8000000040001031
        current = 0xc00000000c60d380
        paca    = 0xc00000001ec9de80   irqmask: 0x03   irq_happened: 0x01
          pid   = 347, comm = kworker/2:1
      ...
      enter ? for help
      [c00000000c747880] c0000000001862d4 update_rq_clock+0x44/0x110 (unreliable)
      [c00000000c7478f0] c000000000198794 update_blocked_averages+0xb4/0x6d0
      [c00000000c7479f0] c000000000198e40 update_nohz_stats+0x90/0xd0
      [c00000000c747a20] c0000000001a13b4 _nohz_idle_balance+0x164/0x390
      [c00000000c747b10] c0000000001a1af8 newidle_balance+0x478/0x610
      [c00000000c747be0] c0000000001a1d48 pick_next_task_fair+0x58/0x480
      [c00000000c747c40] c000000000eaab5c __schedule+0x12c/0x950
      [c00000000c747cd0] c000000000eab3e8 schedule+0x68/0x120
      [c00000000c747d00] c00000000016b730 worker_thread+0x130/0x640
      [c00000000c747da0] c000000000174d50 kthread+0x1a0/0x1b0
      [c00000000c747e10] c00000000000e0f0 ret_from_kernel_thread+0x5c/0x6c
    
    This shows that CPU 2, which was idle, woke up and then appears to
    randomly take an instruction fault on a completely valid area of
    kernel text.
    
    The cause turns out to be the call to hash__mark_rodata_ro(), late in
    boot. Due to the way we layout text and rodata, that function actually
    changes the permissions for all of text and rodata to read-only plus
    execute.
    
    To do the permission change we use a hypervisor call, H_PROTECT. On
    phyp that appears to be implemented by briefly removing the mapping of
    the kernel text, before putting it back with the updated permissions.
    If any other CPU is executing during that window, it will see spurious
    faults on the kernel text and/or data, leading to crashes.
    
    To fix it we use stop machine to collect all other CPUs, and then have
    them drop into real mode (MMU off), while we change the mapping. That
    way they are unaffected by the mapping temporarily disappearing.
    
    We don't see this bug on KVM because KVM always use VPM=1, where
    faults are directed to the hypervisor, and the fault will be
    serialised vs the h_protect() by HPTE_V_HVLOCK.
    
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210331003845.216246-5-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  12. powerpc/mm/64s/hash: Factor out change_memory_range()

    Pull the loop calling hpte_updateboltedpp() out of
    hash__change_memory_range() into a helper function. We need it to be a
    separate function for the next patch.
    
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210331003845.216246-4-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  13. powerpc/64s: Use htab_convert_pte_flags() in hash__mark_rodata_ro()

    In hash__mark_rodata_ro() we pass the raw PP_RXXX value to
    hash__change_memory_range(). That has the effect of setting the key to
    zero, because PP_RXXX contains no key value.
    
    Fix it by using htab_convert_pte_flags(), which knows how to convert a
    pgprot into a pp value, including the key.
    
    Fixes: d94b827 ("powerpc/book3s64/kuap: Use Key 3 for kernel mapping with hash translation")
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: Daniel Axtens <dja@axtens.net>
    Link: https://lore.kernel.org/r/20210331003845.216246-3-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  14. powerpc/pseries: Add key to flags in pSeries_lpar_hpte_updateboltedpp()

    The flags argument to plpar_pte_protect() (aka. H_PROTECT), includes
    the key in bits 9-13, but currently we always set those bits to zero.
    
    In the past that hasn't been a problem because we always used key 0
    for the kernel, and updateboltedpp() is only used for kernel mappings.
    
    However since commit d94b827 ("powerpc/book3s64/kuap: Use Key 3
    for kernel mapping with hash translation") we are now inadvertently
    changing the key (to zero) when we call plpar_pte_protect().
    
    That hasn't broken anything because updateboltedpp() is only used for
    STRICT_KERNEL_RWX, which is currently disabled on 64s due to other
    bugs.
    
    But we want to fix that, so first we need to pass the key correctly to
    plpar_pte_protect(). We can't pass our newpp value directly in, we
    have to convert it into the form expected by the hcall.
    
    The hcall we're using here is H_PROTECT, which is specified in section
    14.5.4.1.6 of LoPAPR v1.1.
    
    It takes a `flags` parameter, and the description for flags says:
    
     * flags: AVPN, pp0, pp1, pp2, key0-key4, n, and for the CMO
       option: CMO Option flags as defined in Table 189‚
    
    If you then go to the start of the parent section, 14.5.4.1, on page
    405, it says:
    
    Register Linkage (For hcall() tokens 0x04 - 0x18)
     * On Call
       * R3 function call token
       * R4 flags (see Table 178‚ “Page Frame Table Access flags field
         definition‚” on page 401)
    
    Then you have to go to section 14.5.3, and on page 394 there is a list
    of hcalls and their tokens (table 176), and there you can see that
    H_PROTECT == 0x18.
    
    Finally you can look at table 178, on page 401, where it specifies the
    layout of the bits for the key:
    
     Bit     Function
     -----------------
     50-54 | key0-key4
    
    Those are big-endian bit numbers, converting to normal bit numbers you
    get bits 9-13, or 0x3e00.
    
    In the kernel we have:
    
      #define HPTE_R_KEY_HI		ASM_CONST(0x3000000000000000)
      #define HPTE_R_KEY_LO		ASM_CONST(0x0000000000000e00)
    
    So the LO bits of newpp are already in the right place, and the HI
    bits need to be shifted down by 48.
    
    Fixes: d94b827 ("powerpc/book3s64/kuap: Use Key 3 for kernel mapping with hash translation")
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210331003845.216246-2-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  15. powerpc/mm/64s: Add _PAGE_KERNEL_ROX

    In the past we had a fallback definition for _PAGE_KERNEL_ROX, but we
    removed that in commit d82fd29 ("powerpc/mm: Distribute platform
    specific PAGE and PMD flags and definitions") and added definitions
    for each MMU family.
    
    However we missed adding a definition for 64s, which was not really a
    bug because it's currently not used.
    
    But we'd like to use PAGE_KERNEL_ROX in a future patch so add a
    definition now.
    
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210331003845.216246-1-mpe@ellerman.id.au
    mpe committed Apr 8, 2021
  16. selftests/powerpc: Test for spurious kernel memory faults on radix

    Previously when mapping kernel memory on radix, no ptesync was
    included which would periodically lead to unhandled spurious faults.
    Mapping kernel memory is used when code patching with Strict RWX
    enabled. As suggested by Chris Riedl, turning ftrace on and off does a
    large amount of code patching so is a convenient way to see this kind
    of fault.
    
    Add a selftest to try and trigger this kind of a spurious fault. It
    tests for 30 seconds which is usually long enough for the issue to
    show up.
    
    Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
    [mpe: Rename it to better reflect what it does, rather than the symptom]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210208032957.1232102-2-jniethe5@gmail.com
    iamjpn authored and mpe committed Apr 8, 2021
  17. powerpc/64s: Fix pte update for kernel memory on radix

    When adding a PTE a ptesync is needed to order the update of the PTE
    with subsequent accesses otherwise a spurious fault may be raised.
    
    radix__set_pte_at() does not do this for performance gains. For
    non-kernel memory this is not an issue as any faults of this kind are
    corrected by the page fault handler. For kernel memory these faults
    are not handled. The current solution is that there is a ptesync in
    flush_cache_vmap() which should be called when mapping from the
    vmalloc region.
    
    However, map_kernel_page() does not call flush_cache_vmap(). This is
    troublesome in particular for code patching with Strict RWX on radix.
    In do_patch_instruction() the page frame that contains the instruction
    to be patched is mapped and then immediately patched. With no ordering
    or synchronization between setting up the PTE and writing to the page
    it is possible for faults.
    
    As the code patching is done using __put_user_asm_goto() the resulting
    fault is obscured - but using a normal store instead it can be seen:
    
      BUG: Unable to handle kernel data access on write at 0xc008000008f24a3c
      Faulting instruction address: 0xc00000000008bd74
      Oops: Kernel access of bad area, sig: 11 [#1]
      LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA PowerNV
      Modules linked in: nop_module(PO+) [last unloaded: nop_module]
      CPU: 4 PID: 757 Comm: sh Tainted: P           O      5.10.0-rc5-01361-ge3c1b78c8440-dirty torvalds#43
      NIP:  c00000000008bd74 LR: c00000000008bd50 CTR: c000000000025810
      REGS: c000000016f634a0 TRAP: 0300   Tainted: P           O       (5.10.0-rc5-01361-ge3c1b78c8440-dirty)
      MSR:  9000000000009033 <SF,HV,EE,ME,IR,DR,RI,LE>  CR: 44002884  XER: 00000000
      CFAR: c00000000007c68c DAR: c008000008f24a3c DSISR: 42000000 IRQMASK: 1
    
    This results in the kind of issue reported here:
      https://lore.kernel.org/linuxppc-dev/15AC5B0E-A221-4B8C-9039-FA96B8EF7C88@lca.pw/
    
    Chris Riedl suggested a reliable way to reproduce the issue:
      $ mount -t debugfs none /sys/kernel/debug
      $ (while true; do echo function > /sys/kernel/debug/tracing/current_tracer ; echo nop > /sys/kernel/debug/tracing/current_tracer ; done) &
    
    Turning ftrace on and off does a large amount of code patching which
    in usually less then 5min will crash giving a trace like:
    
       ftrace-powerpc: (____ptrval____): replaced (4b473b11) != old (60000000)
       ------------[ ftrace bug ]------------
       ftrace failed to modify
       [<c000000000bf8e5c>] napi_busy_loop+0xc/0x390
        actual:   11:3b:47:4b
       Setting ftrace call site to call ftrace function
       ftrace record flags: 80000001
        (1)
        expected tramp: c00000000006c96c
       ------------[ cut here ]------------
       WARNING: CPU: 4 PID: 809 at kernel/trace/ftrace.c:2065 ftrace_bug+0x28c/0x2e8
       Modules linked in: nop_module(PO-) [last unloaded: nop_module]
       CPU: 4 PID: 809 Comm: sh Tainted: P           O      5.10.0-rc5-01360-gf878ccaf250a #1
       NIP:  c00000000024f334 LR: c00000000024f330 CTR: c0000000001a5af0
       REGS: c000000004c8b760 TRAP: 0700   Tainted: P           O       (5.10.0-rc5-01360-gf878ccaf250a)
       MSR:  900000000282b033 <SF,HV,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>  CR: 28008848  XER: 20040000
       CFAR: c0000000001a9c98 IRQMASK: 0
       GPR00: c00000000024f330 c000000004c8b9f0 c000000002770600 0000000000000022
       GPR04: 00000000ffff7fff c000000004c8b6d0 0000000000000027 c0000007fe9bcdd8
       GPR08: 0000000000000023 ffffffffffffffd8 0000000000000027 c000000002613118
       GPR12: 0000000000008000 c0000007fffdca00 0000000000000000 0000000000000000
       GPR16: 0000000023ec37c5 0000000000000000 0000000000000000 0000000000000008
       GPR20: c000000004c8bc90 c0000000027a2d20 c000000004c8bcd0 c000000002612fe8
       GPR24: 0000000000000038 0000000000000030 0000000000000028 0000000000000020
       GPR28: c000000000ff1b68 c000000000bf8e5c c00000000312f700 c000000000fbb9b0
       NIP ftrace_bug+0x28c/0x2e8
       LR  ftrace_bug+0x288/0x2e8
       Call Trace:
         ftrace_bug+0x288/0x2e8 (unreliable)
         ftrace_modify_all_code+0x168/0x210
         arch_ftrace_update_code+0x18/0x30
         ftrace_run_update_code+0x44/0xc0
         ftrace_startup+0xf8/0x1c0
         register_ftrace_function+0x4c/0xc0
         function_trace_init+0x80/0xb0
         tracing_set_tracer+0x2a4/0x4f0
         tracing_set_trace_write+0xd4/0x130
         vfs_write+0xf0/0x330
         ksys_write+0x84/0x140
         system_call_exception+0x14c/0x230
         system_call_common+0xf0/0x27c
    
    To fix this when updating kernel memory PTEs using ptesync.
    
    Fixes: f1cb8f9 ("powerpc/64s/radix: avoid ptesync after set_pte and ptep_set_access_flags")
    Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
    Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
    [mpe: Tidy up change log slightly]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210208032957.1232102-1-jniethe5@gmail.com
    iamjpn authored and mpe committed Apr 8, 2021
  18. powerpc: Spelling/typo fixes

    Various spelling/typo fixes.
    
    Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
    Acked-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    unixbhaskar authored and mpe committed Apr 8, 2021

Commits on Apr 3, 2021

  1. powerpc: Switch to relative jump labels

    Convert powerpc to relative jump labels.
    
    Before the patch, pseries_defconfig vmlinux.o has:
    9074 __jump_table  0003f2a0  0000000000000000  0000000000000000  01321fa8  2**0
    
    With the patch, the same config gets:
    9074 __jump_table  0002a0e0  0000000000000000  0000000000000000  01321fb4  2**0
    
    Size is 258720 without the patch, 172256 with the patch.
    That's a 33% size reduction.
    
    Largely copied from commit c296146 ("arm64/kernel: jump_label:
    Switch to relative references")
    
    Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/828348da7868eda953ce023994404dfc49603b64.1616514473.git.christophe.leroy@csgroup.eu
    chleroy authored and mpe committed Apr 3, 2021
Older