Skip to content
Permalink
Kiran-K/Blueto…
Switch branches/tags

Commits on Jun 16, 2021

  1. Bluetooth: btintel: Support Digital(N) + RF(N-1) combination

    New generation Intel controllers(N) need to support RF from (N-1)
    generation. Since PID comes from OTP present in RF module,
    *setup* function gets mapped to BTUSB_INTEL_NEW instead of
    BTUSB_INTEL_NEWGEN. This patch checks generation of CNVi in
    *setup* of BTUSB_INTEL_NEW and maps callbacks to BTUSB_INTEL_NEWGEN
    if new generation controller is found and attempts *setup* of
    BTUSB_INTEL_NEWGEN.
    
    Signed-off-by: Kiran K <kiran.k@intel.com>
    Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
    Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
    kirankrishnappa-intel authored and intel-lab-lkp committed Jun 16, 2021

Commits on Jun 10, 2021

  1. Bluetooth: Fix Set Extended (Scan Response) Data

    These command do have variable length and the length can go up to 251,
    so this changes the struct to not use a fixed size and then when
    creating the PDU only the actual length of the data send to the
    controller.
    
    Fixes: a0fb372 ("Bluetooth: Use Set ext adv/scan rsp data if controller supports")
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Vudentz authored and holtmann committed Jun 10, 2021

Commits on Jun 4, 2021

  1. Bluetooth: use inclusive language when filtering devices

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    blacklist -> reject list
    whitelist -> accept list
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 4, 2021
  2. Bluetooth: use inclusive language when tracking connections

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    master -> central
    slave  -> peripheral
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 4, 2021
  3. Bluetooth: use inclusive language in HCI role comments

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    master -> initiator (for smp) or central (everything else)
    slave  -> responder (for smp) or peripheral (everything else)
    
    The #define preprocessor terms are unchanged for now to not disturb
    dependent APIs.
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 4, 2021

Commits on Jun 3, 2021

  1. Bluetooth: smp: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  2. Bluetooth: sco: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  3. Bluetooth: msft: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  4. Bluetooth: mgmt: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  5. Bluetooth: amp: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  6. Bluetooth: a2mp: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  7. Bluetooth: 6lowpan: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  8. Bluetooth: hidp: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  9. Bluetooth: cmtp: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021
  10. Bluetooth: bnep: Use the correct print format

    According to Documentation/core-api/printk-formats.rst,
    Use the correct print format. Printing an unsigned int value should use %u
    instead of %d. Otherwise printk() might end up displaying negative numbers.
    
    Signed-off-by: Kai Ye <yekai13@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    yekai123123 authored and holtmann committed Jun 3, 2021

Commits on Jun 2, 2021

  1. Bluetooth: Fix spelling mistakes

    Fix some spelling mistakes in comments:
    udpate  ==> update
    retreive  ==> retrieve
    accidentially  ==> accidentally
    correspondig  ==> corresponding
    adddress  ==> address
    estabilish  ==> establish
    commplete  ==> complete
    Unkown  ==> Unknown
    triggerd  ==> triggered
    transtion  ==> transition
    
    Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Zheng Yongjun authored and holtmann committed Jun 2, 2021
  2. Bluetooth: btusb: Add a new USB ID for RTL8822CE

    Some models of the RTL8822ce utilize a different USB ID. Add this
    new one to the Bluetooth driver.
    
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    lwfinger authored and holtmann committed Jun 2, 2021
  3. Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca bt…

    …soc.
    
    This is btsoc timing issue, after host start to downloading bt firmware,
    ep2 need time to switch from function acl to function dfu, so host add
    20ms delay as workaround.
    
    Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    tjiang123 authored and holtmann committed Jun 2, 2021
  4. Bluetooth: btusb: use default nvm if boardID is 0 for wcn6855.

    if boardID is 0, will use the default nvm file without surfix.
    
    Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    tjiang123 authored and holtmann committed Jun 2, 2021
  5. Bluetooth: btmtkuart: using pm_runtime_resume_and_get instead of pm_r…

    …untime_get_sync
    
    Using pm_runtime_resume_and_get is more appropriate
    for simplifing code
    
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Zhang Qilong authored and holtmann committed Jun 2, 2021
  6. Bluetooth: use inclusive language in comments

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    slave       -> peripheral
    blacklisted -> blocked
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 2, 2021
  7. Bluetooth: use inclusive language in SMP

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    master -> initiator
    slave  -> responder
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 2, 2021
  8. Bluetooth: use inclusive language in HCI LE features

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    master -> central
    slave  -> peripheral
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 2, 2021
  9. Bluetooth: use inclusive language to describe CPB

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced when describing the
    connectionless peripheral broadcast feature:
    master -> central
    slave  -> peripheral
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 2, 2021
  10. Bluetooth: use inclusive language in hci_core.h

    This patch replaces some non-inclusive terms based on the appropriate
    language mapping table compiled by the Bluetooth SIG:
    https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
    
    Specifically, these terms are replaced:
    master -> central
    slave  -> peripheral
    
    These attributes are not used elsewhere in the code.
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed Jun 2, 2021
  11. Bluetooth: mgmt: Fix slab-out-of-bounds in tlv_data_is_valid

    This fixes parsing of LTV entries when the length is 0.
    
    Found with:
    
    tools/mgmt-tester -s "Add Advertising - Success (ScRsp only)"
    
    Add Advertising - Success (ScRsp only) - run
      Sending Add Advertising (0x003e)
      Test condition added, total 1
    [   11.004577] ==================================================================
    [   11.005292] BUG: KASAN: slab-out-of-bounds in tlv_data_is_valid+0x87/0xe0
    [   11.005984] Read of size 1 at addr ffff888002c695b0 by task mgmt-tester/87
    [   11.006711]
    [   11.007176]
    [   11.007429] Allocated by task 87:
    [   11.008151]
    [   11.008438] The buggy address belongs to the object at ffff888002c69580
    [   11.008438]  which belongs to the cache kmalloc-64 of size 64
    [   11.010526] The buggy address is located 48 bytes inside of
    [   11.010526]  64-byte region [ffff888002c69580, ffff888002c695c0)
    [   11.012423] The buggy address belongs to the page:
    [   11.013291]
    [   11.013544] Memory state around the buggy address:
    [   11.014359]  ffff888002c69480: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
    [   11.015453]  ffff888002c69500: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
    [   11.016232] >ffff888002c69580: 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc
    [   11.017010]                                      ^
    [   11.017547]  ffff888002c69600: 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc
    [   11.018296]  ffff888002c69680: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
    [   11.019116] ==================================================================
    
    Fixes: 2bb3687 ("Bluetooth: Unify advertising instance flags check")
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Vudentz authored and holtmann committed Jun 2, 2021
  12. Bluetooth: btrtl: rename USB fw for RTL8761

    According Realteks own BT drivers firmware RTL8761B is for UART
    and RTL8761BU is for USB.
    
    Change existing 8761B to UART and add an 8761BU entry for USB
    
    Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    joakim-tjernlund authored and holtmann committed Jun 2, 2021
  13. Bluetooth: btusb: Add 0x0b05:0x190e Realtek 8761BU (ASUS BT500) device.

    T:  Bus=01 Lev=01 Prnt=01 Port=08 Cnt=04 Dev#= 18 Spd=12   MxCh= 0
    D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
    P:  Vendor=0b05 ProdID=190e Rev= 2.00
    S:  Manufacturer=Realtek
    S:  Product=ASUS USB-BT500
    S:  SerialNumber=xxxxxxxx
    C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
    I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
    E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
    E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
    I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
    I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
    I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
    I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
    I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
    I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
    E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
    Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    joakim-tjernlund authored and holtmann committed Jun 2, 2021

Commits on May 27, 2021

  1. Bluetooth: hci_h5: Add RTL8822CS capabilities

    RTL8822 chipset supports WBS, and this information is conveyed in
    btusb.c. However, the UART driver doesn't have this information just
    yet.
    
    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    apusaka authored and holtmann committed May 27, 2021
  2. Bluetooth: mgmt: Fix the command returns garbage parameter value

    When the Get Device Flags command fails, it returns the error status
    with the parameters filled with the garbage values. Although the
    parameters are not used, it is better to fill with zero than the random
    values.
    
    Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    tedd-an authored and holtmann committed May 27, 2021

Commits on May 26, 2021

  1. Bluetooth: disable filter dup when scan for adv monitor

    Disable duplicates filter when scanning for advertisement monitor for
    the following reasons. The scanning includes active scan and passive
    scan.
    
    For HW pattern filtering (ex. MSFT), Realtek and Qualcomm controllers
    ignore RSSI_Sampling_Period when the duplicates filter is enabled.
    
    For SW pattern filtering, when we're not doing interleaved scanning, it
    is necessary to disable duplicates filter, otherwise hosts can only
    receive one advertisement and it's impossible to know if a peer is still
    in range.
    
    Signed-off-by: Yun-Hao Chung <howardchung@chromium.org>
    Reviewed-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Manish Mandlik <mmandlik@chromium.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Yun-Hao Chung authored and holtmann committed May 26, 2021

Commits on May 20, 2021

  1. Bluetooth: Translate additional address type during le_conn_comp

    When using controller based address resolution, then the destination
    address type during le_conn_complete uses 0x02 & 0x03 if controller
    resolves the destination address(RPA).
    These address types need to be converted back into either 0x00 0r 0x01
    
    Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    sathishnarasimman authored and holtmann committed May 20, 2021
  2. Bluetooth: RFCOMM: Use DEVICE_ATTR_RO macro

    Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
    which makes the code a bit shorter and easier to read.
    
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    YueHaibing authored and holtmann committed May 20, 2021
  3. Bluetooth: btusb: Add support USB ALT 3 for WBS

    Because mSBC frames do not need to be aligned to the SCO packet
    boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC
    data satisfy 60 Bytes avoid payload unaligned situation and fixed
    some headset no voise issue.
    
    USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes.
    
    Signed-off-by: Hilda Wu <hildawu@realtek.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    hildawur authored and holtmann committed May 20, 2021
  4. Bluetooth: btusb: Use firmware_request_nowarn

    This replaces the use of request_firmware to firmware_request_nowarn
    when firmware is optional (firmware is already operational).
    
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Vudentz authored and holtmann committed May 20, 2021
Older