Skip to content
Permalink
Vinod-Koul/drm…
Switch branches/tags

Commits on Nov 16, 2021

  1. drm/msm/dsi: Pass DSC params to drm_panel

    When DSC is enabled, we need to pass the DSC parameters to panel driver
    as well, so add a dsc parameter in panel and set it when DSC is enabled
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  2. drm/msm/dsi: Add support for DSC configuration

    When DSC is enabled, we need to configure DSI registers accordingly and
    configure the respective stream compression registers.
    
    Add support to calculate the register setting based on DSC params and
    timing information and configure these registers.
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  3. drm/msm/dsi: add mode valid callback for dsi_mgr

    Add a mode valid callback for dsi_mgr for checking mode being valid in
    case of DSC. For DSC the height and width needs to be multiple of slice,
    so we check that here
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  4. drm/msm/disp/dpu1: Add DSC support in RM

    This add the bits in RM to enable the DSC blocks
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  5. drm/msm/disp/dpu1: Add support for DSC in topology

    For DSC to work we typically need a 2,2,1 configuration. This should
    suffice for resolutions up to 4k. For more resolutions like 8k this won't
    work.
    
    Also, it is better to use 2 LMs and DSC instances as half width results
    in lesser power consumption as compared to single LM, DSC at full width.
    
    The panel has been tested only with 2,2,1 configuration, so for
    now we blindly create 2,2,1 topology when DSC is enabled
    
    Co-developed-by: Abhinav Kumar <abhinavk@codeaurora.org>
    Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  6. drm/msm: Add missing structure documentation

    Somehow documentation for dspp was missed, so add that
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  7. drm/msm/disp/dpu1: Add support for DSC in encoder

    We need to configure the encoder for DSC configuration and calculate DSC
    parameters for the given timing so this patch adds that support by
    adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled.
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  8. drm/msm/disp/dpu1: Add DSC support in hw_ctl

    Later gens of hardware have DSC bits moved to hw_ctl, so configure these
    bits so that DSC would work there as well
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  9. drm/msm/disp/dpu1: Don't use DSC with mode_3d

    We cannot enable mode_3d when we are using the DSC. So pass
    configuration to detect DSC is enabled and not enable mode_3d
    when we are using DSC
    
    We add a helper dpu_encoder_helper_get_dsc() to detect dsc
    enabled and pass this to .setup_intf_cfg()
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  10. drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

    This adds SDM845 DSC blocks into hw_catalog
    
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  11. drm/msm/disp/dpu1: Add support for DSC in pingpong block

    In SDM845, DSC can be enabled by writing to pingpong block registers, so
    add support for DSC in hw_pp
    
    Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  12. drm/msm/disp/dpu1: Add support for DSC

    Display Stream Compression (DSC) is one of the hw blocks in dpu, so add
    support by adding hw blocks for DSC
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021
  13. drm/msm/dsi: add support for dsc data

    Display Stream Compression (DSC) parameters need to be calculated. Add
    helpers and struct msm_display_dsc_config in msm_drv for this
    msm_display_dsc_config uses drm_dsc_config for DSC parameters.
    
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    vinodkoul authored and intel-lab-lkp committed Nov 16, 2021

Commits on Nov 12, 2021

  1. Merge tag 'drm-misc-fixes-2021-11-11' of git://anongit.freedesktop.or…

    …g/drm/drm-misc into drm-next
    
     * dma-buf: name_lock fixes
     * prime: Keep object ref during mmap
     * nouveau: Fix a refcount issue; Fix device removal; Protect client
       list with dedicated mutex; Fix address CE0 address calculation
     * ttm: Fix race condition during BO eviction
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    
    From: Thomas Zimmermann <tzimmermann@suse.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/YYzY6jeox9EeI15i@linux-uq9g.fritz.box
    airlied committed Nov 12, 2021

Commits on Nov 11, 2021

  1. BackMerge tag 'v5.15' into drm-next

    I got a drm-fixes which had some 5.15 stuff in it, so to avoid
    the mess just backmerge here.
    
    Linux 5.15
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    airlied committed Nov 11, 2021
  2. drm/ttm: Double check mem_type of BO while eviction

    BO might sit in a wrong lru list as there is a small period of memory
    moving and lru list updating.
    
    Lets skip eviction if we hit such mismatch.
    
    Suggested-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: xinhui pan <xinhui.pan@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211110043149.57554-2-xinhui.pan@amd.com
    Signed-off-by: Christian König <christian.koenig@amd.com>
    xinhui pan authored and ChristianKoenigAMD committed Nov 11, 2021
  3. Merge tag 'amd-drm-fixes-5.16-2021-11-10' of https://gitlab.freedeskt…

    …op.org/agd5f/linux into drm-next
    
    amd-drm-fixes-5.16-2021-11-10:
    
    amdgpu:
    - Don't allow partial copy from user for DC debugfs
    - SRIOV fixes
    - GFX9 CSB pin count fix
    - Various IP version check fixes
    - DP 2.0 fixes
    - Limit DCN1 MPO fix to DCN1
    
    amdkfd:
    - SVM fixes
    - Reset fixes
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    From: Alex Deucher <alexander.deucher@amd.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211110222536.7527-1-alexander.deucher@amd.com
    airlied committed Nov 11, 2021

Commits on Nov 10, 2021

  1. Merge tag 'drm-misc-next-fixes-2021-11-10' of git://anongit.freedeskt…

    …op.org/drm/drm-misc into drm-next
    
    Removed the TTM Huge Page functionnality to address a crash, a timeout
    fix for udl, CONFIG_FB dependency improvements, a fix for a circular
    locking depency in imx, a NULL pointer dereference fix for virtio, and a
    naming collision fix for drm/locking.
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    
    From: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211110082114.vfpkpnecwdfg27lk@gilmour
    airlied committed Nov 10, 2021
  2. drm/amdgpu: add missed support for UVD IP_VERSION(3, 0, 64)

    Fixes: 96b8dd4 ("drm/amdgpu/amdgpu_vcn: convert to IP version checking")
    Signed-off-by: Flora Cui <flora.cui@amd.com>
    Signed-off-by: Guchun Chen <guchun.chen@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Guchun Chen authored and Alex Deucher committed Nov 10, 2021
  3. drm/amdgpu: drop jpeg IP initialization in SRIOV case

    Fixes: b05b9c5 ("drm/amdgpu: clean up set IP function")
    Signed-off-by: Guchun Chen <guchun.chen@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Guchun Chen authored and Alex Deucher committed Nov 10, 2021
  4. drm/amd/display: reject both non-zero src_x and src_y only for DCN1x

    [Why]
    Video plane gets rejected for non-zero src_y and src_x on DCN2.x.
    
    [How]
    Limit the rejection till DCN1.x and verified MPO, by dragging video
    playback beyond display's left (0, 0) co-ordinates.
    
    Fixes: d89f604 ("drm/amd/display: Reject non-zero src_y and src_x for video planes")
    Signed-off-by: Shirish S <shirish.s@amd.com>
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Shirish S authored and Alex Deucher committed Nov 10, 2021
  5. Merge tag 'drm-intel-next-fixes-2021-11-09' of git://anongit.freedesk…

    …top.org/drm/drm-intel into drm-next
    
    Couple Reverts, build fix, couple virtualization fixes,
    blank screen and other display rates fixes, and more.
    
    Four patches targeting stable in here.
    
    Display Fixes:
    - DP rates related fixes (Imre, Jani)
    - A Revert on disaling dual eDP that was causing state readout problems (Jani)
    - put the cdclk vtables in const data (Jani)
    - Fix DVO port type for moder platforms (Ville)
    - Fix blankscreen by turning DP++ TMDS output buffers on encoder->shutdown (Ville)
    - CCS FBs related fixes (Imre)
    
    GT fixes:
    - Fix recursive lock in GuC submission (Matt Brost)
    - Revert guc_id from i915_request tracepoint (Joonas)
    - Build fix around dmabuf (Matt Auld)
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    
    From: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/YYsBif3HMi8GjLoU@intel.com
    airlied committed Nov 10, 2021
  6. Merge tag 'drm-misc-next-fixes-2021-11-05' of git://anongit.freedeskt…

    …op.org/drm/drm-misc into drm-next
    
    A refcounting fix for outstanding fence callbacks.
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    
    From: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211105074318.oy6rwjr5wcw6qpjj@gilmour
    airlied committed Nov 10, 2021

Commits on Nov 9, 2021

  1. drm/amd/display: Add callbacks for DMUB HPD IRQ notifications

    [Why]
    We need HPD IRQ notifications (RX, short pulse) to properly handle
    DP MST for DPIA connections.
    
    [How]
    A null pointer exception currently occurs when these are received
    so add a check to validate that we have a handler installed for
    the notification.
    
    Extend the HPD handler to also handle HPD IRQ (RX) since the logic is
    the same.
    
    Fixes: e27c41d ("drm/amd/display: Support for DMUB HPD interrupt handling")
    
    Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
    Reviewed-by: Jude Shih <shenshih@amd.com>
    Acked-by: Anson Jacob <Anson.Jacob@amd.com>
    Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Nicholas Kazlauskas authored and Alex Deucher committed Nov 9, 2021
  2. drm/amd/display: Don't lock connection_mutex for DMUB HPD

    [Why]
    Per DRM spec we only need to hold that lock when touching
    connector->state - which we do not do in that handler.
    
    Taking this locking introduces unnecessary dependencies with other
    threads which is bad for performance and opens up the potential for
    a deadlock since there are multiple locks being held at once.
    
    [How]
    Remove the connection_mutex lock/unlock routine and just iterate over
    the drm connectors normally. The iter helpers implicitly lock the
    connection list so this is safe to do.
    
    DC link access also does not need to be guarded since the link
    table is static at creation - we don't dynamically add or remove links,
    just streams.
    
    Fixes: e27c41d ("drm/amd/display: Support for DMUB HPD interrupt handling")
    
    Reviewed-by: Jude Shih <shenshih@amd.com>
    Acked-by: Anson Jacob <Anson.Jacob@amd.com>
    Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Nicholas Kazlauskas authored and Alex Deucher committed Nov 9, 2021
  3. drm/amd/display: Add comment where CONFIG_DRM_AMD_DC_DCN macro ends

    Trivial patch which adds a comment for macro
    endif's in amdgpu_dm.c
    
    Reviewed-by: Ariel Bernstein <Eric.Bernstein@amd.com>
    Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
    Acked-by: Anson Jacob <Anson.Jacob@amd.com>
    Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
    Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Anson Jacob authored and Alex Deucher committed Nov 9, 2021
  4. drm/amdkfd: Fix retry fault drain race conditions

    The check for whether to drain retry faults must be under the mmap write
    lock to serialize with munmap notifier callbacks.
    
    We were also missing checks on child ranges. To fix that, simplify the
    logic by using a flag rather than checking on each prange. That also
    allows draining less freqeuntly when many ranges are unmapped at once.
    
    Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Tested-by: Philip Yang <Philip.Yang@amd.com>
    Tested-by: Alex Sierra <Alex.Sierra@amd.com>
    Reviewed-by: Philip Yang <Philip.Yang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    fxkamd authored and Alex Deucher committed Nov 9, 2021
  5. drm/amdkfd: lower the VAs base offset to 8KB

    The low 16MB of virtual address space are currently reserved for kernel
    mode allocations mapped into user virtual address space. This causes
    conflicts with HMM/SVM mappings at low virtual addresses. We tried to
    move those kernel mode allocations to the upper half of the 64-bit
    virtual address space for GFX9, which is naturally reserved for kernel
    use. However, TBA (trap handler code) has problems to access addresses
    in the high virtual space. We have decided to set this to 8KB of the
    lower address space as a temporary fix, while investigate TBA address
    problem. It is very unlikely for user space to map memory at this low
    region.
    
    Signed-off-by: Alex Sierra <alex.sierra@amd.com>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    alexsierrag authored and Alex Deucher committed Nov 9, 2021
  6. drm/amd/display: fix exit from amdgpu_dm_atomic_check() abruptly

    make action upon failure in "drm_atomic_add_affected_connectors()"
    consistent with the rest of failures in amdgpu_dm_atomic_check().
    
    Signed-off-by: Shirish S <shirish.s@amd.com>
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Shirish S authored and Alex Deucher committed Nov 9, 2021
  7. drm/amd/amdgpu: fix the kfd pre_reset sequence in sriov

    The KFD pre_reset should be called before reset been executed, it will
    hold the lock to prevent other rocm process to sent the packlage to hiq
    during host execute the real reset on the HW
    
    Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    shaoyunl authored and Alex Deucher committed Nov 9, 2021
  8. drm/amdgpu: fix uvd crash on Polaris12 during driver unloading

    There was a change(below) target for such issue:
    d82e2c2 ("drm/amdgpu: Fix crash on device remove/driver unload")
    But the fix for VI ASICs was missing there. This is a supplement for
    that.
    
    Fixes: d82e2c2 ("drm/amdgpu: Fix crash on device remove/driver unload")
    
    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Evan Quan authored and Alex Deucher committed Nov 9, 2021
  9. drm/i915/adlp/fb: Prevent the mapping of redundant trailing padding N…

    …ULL pages
    
    So far the remapped view size in GTT/DPT was padded to the next aligned
    offset unnecessarily after the last color plane with an unaligned size.
    Remove the unnecessary padding.
    
    Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
    Fixes: 3d1adc3 ("drm/i915/adlp: Add support for remapping CCS FBs")
    Signed-off-by: Imre Deak <imre.deak@intel.com>
    Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211026225105.2783797-3-imre.deak@intel.com
    (cherry picked from commit 6b6636e)
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    ideak authored and rodrigovivi committed Nov 9, 2021
  10. drm/i915/fb: Fix rounding error in subsampled plane size calculation

    For NV12 FBs with odd main surface tile-row height the CCS surface
    height was incorrectly calculated 1 less than the actual value. Fix this
    by rounding up the result of divison. For consistency do the same for
    the CCS surface width calculation.
    
    Fixes: b3e57bc ("drm/i915/tgl: Gen-12 render decompression")
    Signed-off-by: Imre Deak <imre.deak@intel.com>
    Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211026225105.2783797-2-imre.deak@intel.com
    (cherry picked from commit 2ee5ef9)
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    ideak authored and rodrigovivi committed Nov 9, 2021
  11. drm/i915/hdmi: Turn DP++ TMDS output buffers back on in encoder->shut…

    …down()
    
    Looks like our VBIOS/GOP generally fail to turn the DP dual mode adater
    TMDS output buffers back on after a reboot. This leads to a black screen
    after reboot if we turned the TMDS output buffers off prior to reboot.
    And if i915 decides to do a fastboot the black screen will persist even
    after i915 takes over.
    
    Apparently this has been a problem ever since commit b2ccb82 ("drm/i915:
    Enable/disable TMDS output buffers in DP++ adaptor as needed") if one
    rebooted while the display was turned off. And things became worse with
    commit fe0f1e3 ("drm/i915: Shut down displays gracefully on reboot")
    since now we always turn the display off before a reboot.
    
    This was reported on a RKL, but I confirmed the same behaviour on my
    SNB as well. So looks pretty universal.
    
    Let's fix this by explicitly turning the TMDS output buffers back on
    in the encoder->shutdown() hook. Note that this gets called after irqs
    have been disabled, so the i2c communication with the DP dual mode
    adapter has to be performed via polling (which the gmbus code is
    perfectly happy to do for us).
    
    We also need a bit of care in handling DDI encoders which may or may
    not be set up for HDMI output. Specifically ddc_pin will not be
    populated for a DP only DDI encoder, in which case we don't want to
    call intel_gmbus_get_adapter(). We can handle that by simply doing
    the dual mode adapter type check before calling
    intel_gmbus_get_adapter().
    
    Cc: <stable@vger.kernel.org> # v5.11+
    Fixes: fe0f1e3 ("drm/i915: Shut down displays gracefully on reboot")
    Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4371
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211029191802.18448-2-ville.syrjala@linux.intel.com
    Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
    (cherry picked from commit 49c55f7)
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    vsyrjala authored and rodrigovivi committed Nov 9, 2021
  12. drm/locking: fix __stack_depot_* name conflict

    Commit cd06ab2 ("drm/locking: add backtrace for locking contended
    locks without backoff") added functions named __stack_depot_* in drm
    which conflict with stack depot. Rename to __drm_stack_depot_*.
    
    v2 by Jani:
    - Also rename __stack_depot_print
    
    References: https://lore.kernel.org/r/20211015202648.258445ef@canb.auug.org.au
    Fixes: cd06ab2 ("drm/locking: add backtrace for locking contended locks without backoff")
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211018085113.27033-1-jani.nikula@intel.com
    (cherry picked from commit c4f08d7)
    sfrothwell authored and jnikula committed Nov 9, 2021
Older