Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N163 sample length limit fix #118

Closed
koitsu opened this issue Feb 3, 2015 · 1 comment
Closed

N163 sample length limit fix #118

koitsu opened this issue Feb 3, 2015 · 1 comment

Comments

@koitsu
Copy link
Contributor

@koitsu koitsu commented Feb 3, 2015

Recently it was discussed on nesdev that Nestopia's N163 emulation doesn't support sample lengths larger than 32. The N163 information at the time was incorrect (including on our nesdev wiki, which was updated in 2011 to reflect correct info). Games like Rolling Thunder use lengths >32.

Thread: http://forums.nesdev.com/viewtopic.php?f=6&t=12326

Fixes:

https://github.com/rdanbrook/nestopia/blob/master/source/core/board/NstBoardNamcot163.cpp#L292

Change 0x20UL to 0x100UL

https://github.com/rdanbrook/nestopia/blob/master/source/core/board/NstBoardNamcot163.hpp#L84

Change 0x1C to 0xFC

@rdanbrook
Copy link
Member

@rdanbrook rdanbrook commented Feb 8, 2015

I'll make the change in the very near future.

Loading

@rdanbrook rdanbrook closed this Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants