Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat module: literally just renaming some stuff #108

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

RedFlames
Copy link
Collaborator

This isn't strictly necessary, but it is what I based my rewrite of the command arg parsing on, so I'm PR-ing this first in the hopes that the other PR will have nicer diffs (the other PR was made on top of this one)

What I did here:

  • give all the chat command classes and stuff the namespace Celeste.Mod.CelesteNet.Server.Chat.Cmd within the chat module
  • Rename everything that had the ChatCMD prefix, I mostly just replaced that with Cmd although I think in some places I did something else. This is really just an "aesthetics" refactor >w>
  • some examples:
    • ChatCMD -> ChatCmd (could maybe rename this to Cmd as well, but idk)
    • ChatCMDChannelChat -> CmdChannelChat
    • ChatCMDTP -> CmdTP
    • ...
    • ChatCMDArg -> CmdArg
    • ChatCMDArgType -> CmdArgType
    • ChatCMDEnv -> CmdEnv
  • Oh and I did set the readonly ChatModule Chat field in CmdEnv to private because only CmdArg was only using it to get to CmdEnv.Chat.Server which now goes through CmdEnv.Server instead. CmdBan was doing a similar thing.

I didn't actually delete/add any files, that's just git not picking up on my renamed files. 🙂

@RedFlames RedFlames added the Chat label Jul 13, 2023
@RedFlames RedFlames added this to the v2.3.0 milestone Jul 23, 2023
@RedFlames RedFlames merged commit e58f34e into 0x0ade:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant