Chat module: literally just renaming some stuff #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't strictly necessary, but it is what I based my rewrite of the command arg parsing on, so I'm PR-ing this first in the hopes that the other PR will have nicer diffs (the other PR was made on top of this one)
What I did here:
Celeste.Mod.CelesteNet.Server.Chat.Cmd
within the chat moduleChatCMD
prefix, I mostly just replaced that withCmd
although I think in some places I did something else. This is really just an "aesthetics" refactor >w>ChatCMD
->ChatCmd
(could maybe rename this toCmd
as well, but idk)ChatCMDChannelChat
->CmdChannelChat
ChatCMDTP
->CmdTP
ChatCMDArg
->CmdArg
ChatCMDArgType
->CmdArgType
ChatCMDEnv
->CmdEnv
readonly ChatModule Chat
field inCmdEnv
toprivate
because onlyCmdArg
was only using it to get toCmdEnv.Chat.Server
which now goes throughCmdEnv.Server
instead. CmdBan was doing a similar thing.I didn't actually delete/add any files, that's just git not picking up on my renamed files. 🙂