-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat QoL: Tab completions #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds have auth-level info, etc.
…potential array out of bounds crash.
…command is an alias to something
…would match makes sure the base non-alias shows up too. Added an extra flag to hide the aliasing between '/channel' and '/join' because it looks a bit funky otherwise.
Includes Popax' ping code but not the player list fix for that yet
This was referenced Aug 18, 2022
…ss that were in DataCommandList
This was referenced Oct 14, 2022
Merged
RedFlames
changed the title
Chat QoL improvements: Scrolling, Tab completions, ...
Chat QoL: Tab completions
Oct 23, 2022
… if they hadn't been set at all (e.g. on update). Also, make the 'linked' OUI Slider nudging less buggy
…ctly apply this to different UI scale settings.
…ing care of it with different logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
If #46 gets merged, this becomes Client-side only, currently you can compare the changes here:
https://github.com/RedFlames/CelesteNet/compare/chat-qol-server-only-new..chat-qol-improvements?diff=unified
Plus there's #47 and #48 splitting off different parts of this, leaving only the Tab Completion (client-side) to be merged here, afterwards.
I'm pretty happy with where this feature branch of mine is at as it stands, so I'll make another PR. I know I still have two other ones that await merging, and this one is a bit heavier too...
Overview:
/kick
as a completion option)/
at the start of the input or after/help ...
/tp ...
)/join
aka/channel
/gc
or/globa
... -> suggests only/globalchat
-> pressing Tab turns either one into/gc
)