Chat QoL: Tab completions - Server-side only #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds have auth-level info, etc.
…potential array out of bounds crash.
…command is an alias to something
…would match makes sure the base non-alias shows up too. Added an extra flag to hide the aliasing between '/channel' and '/join' because it looks a bit funky otherwise.
Includes Popax' ping code but not the player list fix for that yet
…nds have auth-level info, etc.
…command is an alias to something
…would match makes sure the base non-alias shows up too. Added an extra flag to hide the aliasing between '/channel' and '/join' because it looks a bit funky otherwise.
|
Accidentally merged the entirety of #26 into this and even with a revert, the whole commit history is trashed here now, so closing here and opened new PR with new cherry-pick branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only the server-side stuff necessary for tab completion.
(This is cherry-picked from #26)
The server now has some basic info about:
/kickas a completion option)... and it can send this info to the client.
If a client doesn't understand the
DataCommandListDataType it will just be ignored and current clients run as usual.If we merge & release this first, dev clients could properly evalute #26 on the live server.
Things to note:
The
using static Celeste.Mod.CelesteNet.DataTypes.DataCommandList;is probably a bit of a sin?... I threw that into every ChatCMD... class just so that I could use theenum CompletionTypevalues there...