Permalink
Browse files

ntopng: Fix a couple of bugs.

This fixes a couple of bugs reported by the AUR user pdifeo:
  - The systemd unit file was named incorrectly.
  - The joint script arguments were not being passed on.

From pdifeo's original comment:

> In the file ntopng.service there is
> ....
> ExecStart=/usr/bin/ntopng -i %I
>
> and in the file /usr/bin/ntopng
> #!/bin/bash
> cd /usr/share/ntopng
> ./ntopng
>
> If I understand, the %I parameter is never passed to executable.
> The first issue is on ntopng.service. The correct file name must be
> ntopng@.service. The second issue is that ./ntopng is called into
> script without $@ for passing parameters. so the file /usr/bin/ntopng
> should be
>
> #!/bin/bash
> cd /usr/share/ntopng
> ./ntopng $@
>
> With these changes the service start well with
> systemctl start ntopng@<interface name>
>
> Another issue is on compilation stage. Missing
>
> make geoip
>
> for geoip database creation.
>
> There is other little problems with data directories. I try to
> understand better.

The `make geoip` issue was fixed in a previous commit.
  • Loading branch information...
1 parent 993cf37 commit bfc390349603f4aa769bae6aa14c50c05024accd @0x91 committed Sep 15, 2013
Showing with 3 additions and 4 deletions.
  1. +3 −4 ntopng/PKGBUILD
  2. 0 ntopng/{ntopng.service → ntopng@.service}
View
@@ -3,18 +3,17 @@
pkgname=ntopng
pkgver=1.0
-pkgrel=2
+pkgrel=3
pkgdesc='The next generation version of the original ntop, a network traffic probe that shows the network usage'
arch=('x86_64' 'i686')
url='http://www.ntop.org/'
license=('GPL3')
depends=('redis' 'libxml2' 'geoip' 'libpcap' 'libnet' 'lua' 'zeromq' 'gd'
'gdbm' 'pcre' 'rrdtool' 'psutils')
source=("http://downloads.sourceforge.net/project/ntop/ntopng/ntopng-${pkgver}.tar.gz"
- ntopng.service)
+ ntopng@.service)
md5sums=('d108d1a23fe515426139118e5c2029b8'
'5d3dd12fd77756138f45769e31b67505')
-
build() {
cd "$srcdir/ntopng-$pkgver"
./configure --prefix=/usr
@@ -42,7 +41,7 @@ package() {
cat > "$pkgdir/usr/bin/ntopng" <<EOF
#!/bin/sh
cd /usr/share/ntopng
-./ntopng
+./ntopng "\$@"
EOF
chmod +x "$pkgdir/usr/bin/ntopng"
}
File renamed without changes.

0 comments on commit bfc3903

Please sign in to comment.