-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-666: Fix eth_getLogs
index issue
#1533
Conversation
f620b3c
to
ad920a2
Compare
ad920a2
to
e2669bf
Compare
Just confirming, this will fix for logs returned by both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AFAIK, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes issue where
eth_getLog
rpc call did not return correct values forLogIndex
for block logs.Before, the
LogIndex
field was set by transaction instead of block. For example, if block had two transactions with two logs each, the call would return log indexes: 0, 1, 0, 1, instead of: 0, 1, 2, 3.This PR added a UT for this.
Changes include
Checklist
Testing