fix: fixing forced batches error handling and normal batches transaction level error handling. #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psykepro
force-pushed
the
feature/fix-forced-batches-err-handling
branch
2 times, most recently
from
9265c2b
to
f69f520
Compare
ToniRamirezM
approved these changes
May 15, 2023
ARR552
requested changes
May 15, 2023
| @@ -399,7 +398,8 @@ func (f *finalizer) processTransaction(ctx context.Context, tx *TxTracker) error | |||
| // handleTxProcessResp handles the response of transaction processing. | |||
| func (f *finalizer) handleTxProcessResp(ctx context.Context, tx *TxTracker, result *state.ProcessBatchResponse, oldStateRoot common.Hash) error { | |||
| // Handle Transaction Error | |||
| if result.Responses[0].RomError != nil && !errors.Is(result.Responses[0].RomError, runtime.ErrExecutionReverted) { | |||
| if !result.IsBatchProcessed { | |||
| // If intrinsic error or OOC error, we skip adding the transaction to the batch | |||
| f.handleTransactionError(ctx, result, tx) | |||
| return result.Responses[0].RomError | |||
There was a problem hiding this comment.
Why returning thefirst response?
There was a problem hiding this comment.
Here we process 1 by 1 we always can have only 1 response
sequencer/finalizer.go
Outdated
| if err != nil { | ||
| return lastBatchNumberInState, stateRoot | ||
| } | ||
| _ = f.handleForcedTxsProcessResp(request, response, stateRoot) |
There was a problem hiding this comment.
why do we ignore the error?
There was a problem hiding this comment.
because nothing happens even if we have error I can just remove returning it
sequencer/finalizer.go
Outdated
Comment on lines
426
to
428
| romErr := executor.RomErrorCode(txResp.RomError) | ||
| if txResp.RomError != nil { |
There was a problem hiding this comment.
Suggested change
| romErr := executor.RomErrorCode(txResp.RomError) | |
| if txResp.RomError != nil { | |
| if txResp.RomError != nil { | |
| romErr := executor.RomErrorCode(txResp.RomError) | |
sequencer/finalizer.go
Outdated
| return txResp.RomError | ||
| } else if executor.IsIntrinsicError(romErr) { | ||
| // If we have an intrinsic error, we should continue processing the batch, but skip the transaction | ||
| if txResp.RomError != nil { |
krlosMata
reviewed
May 15, 2023
sequencer/finalizer.go
Outdated
| log.Warnf("handleForcedBatchProcessResp: ROM out of counters error: %s", txResp.RomError) | ||
| romErr := executor.RomErrorCode(txResp.RomError) | ||
| if txResp.RomError != nil { | ||
| if executor.IsROMOutOfCountersError(romErr) { |
There was a problem hiding this comment.
if the batch has an out of counters, no transaction should be added.
I thinks that here, if there is the error in the 4th transaction for example, the first 3 ones will be stored and they should not
There was a problem hiding this comment.
What about the list of errors that increase the nonce??
Those will be added. We don't skip them.
Psykepro
force-pushed
the
feature/fix-forced-batches-err-handling
branch
from
f69f520
to
f02c4b2
Compare
ARR552
approved these changes
May 15, 2023
…ion level error handling. Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Psykepro
force-pushed
the
feature/fix-forced-batches-err-handling
branch
from
f02c4b2
to
96a6a5a
Compare
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
…hub.com/0xPolygonHermez/zkevm-node into feature/fix-forced-batches-err-handling
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2099.
What does this PR do?
Fixing:
error handlingforForced Batches.transaction level error handlingforNormal Batches.ErrIntrinsicInvalidBatchGasLimitinRomErrorCodefunction of the stateReviewers
Main reviewers:
Codeowner reviewers: