Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type suffixes to all keys when logging #275

Merged
merged 4 commits into from Jul 18, 2019

Conversation

@albrow
Copy link
Member

albrow commented Jul 17, 2019

This PR will help fix field mapping conflicts in Elasticsearch. When we have two separate logs with the same field name but different types, Elasticsearch cannot correctly index them, which often results in log messages being lost. If we add a type suffix, it will no longer be possible to have the same field name but different types.

albrow added 2 commits Jul 17, 2019
@albrow albrow requested a review from fabioberger Jul 17, 2019
loghooks/key_suffix_hook.go Outdated Show resolved Hide resolved
Co-Authored-By: Fabio B <me@fabioberger.com>
@albrow albrow merged commit 97bb9f6 into development Jul 18, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/logging-key-suffix branch Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.