Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs (part two) #287

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@albrow
Copy link
Member

albrow commented Jul 19, 2019

Changes in this PR:

  • Only log peer connection errors the first time we fail to connect to a peer. This errors are usually not a problem and are expected to come up a lot when peers connect and then disconnect from the network. Only logging the first error will still allow us to diagnose potential connection issues without them dominating the logs.
  • Move the message about initializing core.App to the end of initialization. This means we can include "myPeerID" in the message.
albrow added 2 commits Jul 19, 2019
@albrow albrow requested a review from fabioberger Jul 19, 2019
@albrow albrow changed the title Fix/improve logs part two Improve logs (part two) Jul 19, 2019
@albrow albrow merged commit 35ef738 into development Jul 19, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/improve-logs-part-two branch Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.