Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout of 30s (per package) for tests #310

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@albrow
Copy link
Member

albrow commented Jul 26, 2019

Fixes #183.

Go offers a --timeout flag which will cause go test to fail if the tests for any package take too long. It would technically be better to go through each test and eliminate situations where the test could hang. In practice, that can be difficult and it is easy to miss some edge cases. I think the --timeout flag will be good enough.

@albrow albrow requested a review from fabioberger Jul 26, 2019
@albrow albrow merged commit c9a6a4d into development Jul 26, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/test-timeouts branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.