Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of "fetching block logs" message #314

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@albrow
Copy link
Member

albrow commented Jul 27, 2019

@fabioberger I think the verbosity of this log should change from Info to Trace. Whenever I run Mesh locally for quick tests, this log message is taking up a large percentage of the total number of logs. I don't think it is helpful to see hundreds of logs for what is a pretty common occurrence. What do you think?

@albrow albrow requested a review from fabioberger Jul 27, 2019
@fabioberger

This comment has been minimized.

Copy link
Contributor

fabioberger commented Jul 27, 2019

Does it still print out a one-liner, explaining why it's not starting the node immediately? I'm fine with removing this so long as there is still a log explaining what the node is doing.

@albrow albrow merged commit 6625449 into development Jul 29, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/reduce-block-logs-verbosity branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.