Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Handle stored orders differently if flagged for removal #316

Merged
merged 6 commits into from Jul 30, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Jul 27, 2019

Fixes: #199

Copy link
Member

albrow left a comment

@fabioberger this change messes up some of the other logic in the core package. For example, we assume that every order in ValidationResults.Accepted is a new unique valid order and log a message indicating that. It's important that we don't log this message for orders which we've already seen. It might also have implications for our peer ranking system but at this point it's too early to tell.

I think we still need a way to indicate that an order is valid but already stored. What do you think?

fabioberger added 5 commits Jul 27, 2019
…d for removal, reject, otherwise accept without revalidation
…ceptedOrderInfo since IsNew doesn't make sense in this context
…eady stored, fillable orders
@fabioberger fabioberger force-pushed the refactor/removeAlreadyAdded branch from 9f74832 to 3a579ec Jul 30, 2019
@fabioberger fabioberger force-pushed the refactor/removeAlreadyAdded branch from 7251b51 to 9ed5c03 Jul 30, 2019
@albrow
albrow approved these changes Jul 30, 2019
@fabioberger fabioberger merged commit 03c01dc into development Jul 30, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.