Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockwatch: Fix number to hex encoding bug #353

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Aug 13, 2019

Fixes: #342 & #323

Use hexutil.EncodeBig instead of Bytes2Hex when converting BigInt to hex to avoid leading zeroes which are considered invalid encoding by the Ethereum JSON-RPC spec.

fabioberger added 2 commits Aug 13, 2019
…void leading zeroes
@albrow
albrow approved these changes Aug 14, 2019
@albrow albrow merged commit 09c9aa6 into development Aug 14, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/leadingZeroesInHex branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.