Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockwatch: Separate blockwatch dependency on meshdb #355

Merged
merged 8 commits into from Sep 5, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Aug 13, 2019

Fixes: #343

Initial attempt at making the blockwatch package independent of the meshdb package so that any persistence layer could be used with it. This is a per-requisite to external teams being able to import the blockwatch package into their own projects.

TODO

  • Add unit tests for blockstack.BlockStack
@fabioberger fabioberger force-pushed the refactor/blockwatchMoreStandalone branch from 6531030 to 6287adf Sep 2, 2019
@fabioberger fabioberger changed the title WIP blockwatch: Separate blockwatch dependency on meshdb blockwatch: Separate blockwatch dependency on meshdb Sep 2, 2019
@fabioberger fabioberger requested a review from albrow Sep 2, 2019
@fabioberger fabioberger self-assigned this Sep 2, 2019
@fabioberger fabioberger force-pushed the refactor/blockwatchMoreStandalone branch from 6287adf to 77da4a3 Sep 3, 2019
ethereum/blockstack/block_stack.go Outdated Show resolved Hide resolved
ethereum/miniheader/miniheader.go Show resolved Hide resolved
ethereum/blockwatch/block_watcher.go Outdated Show resolved Hide resolved
@albrow

This comment has been minimized.

Copy link
Member

albrow commented Sep 3, 2019

@fabioberger overall looks really good. I just left some suggestions about naming/organization. I could be convinced to merge as is; just want to talk about it first.

@albrow albrow self-requested a review Sep 4, 2019
Copy link
Member

albrow left a comment

@fabioberger Looks like the build is failing because SimpleStack and DBStack no longer implement the Stack interface. You just need to rename Inspect to PeekAll in each implementation.

@fabioberger fabioberger force-pushed the refactor/blockwatchMoreStandalone branch from d5899e1 to de15ae3 Sep 5, 2019
@albrow albrow self-requested a review Sep 5, 2019
@albrow
albrow approved these changes Sep 5, 2019
@fabioberger fabioberger merged commit 11ce9db into development Sep 5, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the refactor/blockwatchMoreStandalone branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.