Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroex: Cache order hash calculations #365

Closed
wants to merge 1 commit into from

Conversation

@albrow
Copy link
Member

albrow commented Aug 16, 2019

Copied over from #167, this PR introduces a performance optimization by caching order hashes instead of computing them multiple times for the same order.

This optimization has become increasingly relevant as we're testing Mesh in the browser. Performance profiling in Firefox and Chrome revealed that computing order hashes was taking a significant amount of CPU time. This PR reduces it from 2.5% total CPU time to 0.6%.

@albrow albrow requested a review from fabioberger Aug 16, 2019
@albrow albrow changed the title zeroed: Cache order hash calculations zeroex: Cache order hash calculations Aug 16, 2019
@albrow albrow added the performance label Aug 16, 2019
@albrow albrow force-pushed the feature/order-hash-caching branch from 39e945e to 1a07b10 Aug 16, 2019
@albrow

This comment has been minimized.

Copy link
Member Author

albrow commented Aug 20, 2019

The commit history on the development branch shows that this PR was actually merged, but GitHub seems to be confused. I'm going to close it here.

Screen Shot 2019-08-20 at 11 16 03 AM

@albrow albrow closed this Aug 20, 2019
albrow added a commit that referenced this pull request Sep 5, 2019
zeroex: Cache order hash calculations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.