Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/mesh: Exit the process if the database is closed #370

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@albrow
Copy link
Member

albrow commented Aug 22, 2019

Should fix #319. It's difficult to test because I can't reproduce the original error.

I did do a bit of manual testing by adding some code to forcibly close the database after 30 seconds. I can confirm that in this case Mesh exited and logged the error as expected.

@albrow albrow requested a review from fabioberger Aug 22, 2019
@albrow albrow changed the title Exit the process if the database is closed cmd/mesh: Exit the process if the database is closed Aug 23, 2019
@albrow albrow added the bug label Aug 23, 2019
Copy link
Contributor

fabioberger left a comment

LGTM

@albrow albrow merged commit d3d2410 into development Aug 23, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/exit-on-db-closed-error branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.