Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orderwatch: Avoid re-adding expired orders to OrderWatcher #385

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Sep 3, 2019

Fixes: #364

This PR fixes the issue of expired orders were being re-added to OrderWatcher when fill/cancel events for that order trigger. Instead, the fill/cancel order events should still fire, but the order should not be re-added.

@fabioberger fabioberger self-assigned this Sep 3, 2019
@fabioberger fabioberger requested a review from albrow Sep 3, 2019
…en fill/cancel for them were found. This fix also makes it such that fill/cancel events still trigger for expired orders
@fabioberger fabioberger force-pushed the fix/expirationEventFiring branch from 8d68ecd to 369a6b8 Sep 3, 2019
@albrow
albrow approved these changes Sep 3, 2019
@fabioberger fabioberger merged commit 44982ca into development Sep 4, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the fix/expirationEventFiring branch Sep 4, 2019
fabioberger added a commit that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.