Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove maxOrderExpirationDuration constraint #400

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Sep 6, 2019

Since we plan to remove the oldest orders from the DB once it becomes full, we no longer have as strong of a need to enforce a max expiration time on orders. This PR removes this constraint.

@fabioberger fabioberger requested a review from albrow Sep 6, 2019
@fabioberger fabioberger self-assigned this Sep 6, 2019
Copy link
Member

albrow left a comment

Mostly looks good to me, just two small comments.

CHANGELOG.md Show resolved Hide resolved
core/validation.go Show resolved Hide resolved
@fabioberger fabioberger force-pushed the refactor/removeExpiryConstraint branch from d4b7d68 to 0a242bd Sep 12, 2019
@albrow albrow self-requested a review Sep 12, 2019
@albrow
albrow approved these changes Sep 12, 2019
@albrow albrow merged commit f29a927 into development Sep 12, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the refactor/removeExpiryConstraint branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.