Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orderwatch: Fix fillableTakerAssetAmount DB update bug #439

Merged
merged 3 commits into from Oct 4, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Oct 3, 2019

This PR fixes a bug in OrderWatcher where we were not updating an order's fillableTakerAssetAmount in the DB if an order was partially filled, or if it's fillability increased due to a block re-org.

fabioberger added 2 commits Oct 3, 2019
…ility increased and add missing test for paritally filling order
@fabioberger fabioberger requested a review from albrow Oct 3, 2019
@albrow
albrow approved these changes Oct 3, 2019
@fabioberger fabioberger merged commit 60b1ba5 into development Oct 4, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the fix/fillableTakerAssetAmountDbUpdates branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.