Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom network ID/custom contract addresses #445

Merged
merged 3 commits into from Oct 15, 2019

Conversation

@albrow
Copy link
Member

albrow commented Oct 15, 2019

This PR adds support for declaring a custom network ID and custom contract addresses. This is primarily intended for testing purposes and allows Mesh to be used with local Ethereum networks other than Ganache.

albrow added 2 commits Oct 11, 2019
@albrow albrow requested a review from fabioberger Oct 15, 2019
@albrow albrow added the enhancement label Oct 15, 2019
// "erc20Proxy": "0x1dc4c1cefef38a777b15aa20260a54e584b16c48",
// "erc721Proxy": "0x1d7022f5b17d2f8b695918fb48fa1089c9f85401"
// }
// }

This comment has been minimized.

Copy link
@fabioberger

fabioberger Oct 15, 2019

Contributor

Since there is never a reason to supply more then a single set of contract addresses, why don't we remove the networkID nesting and assume the supplied addresses are for the specified networkID (an already existing configuration option)?

This comment has been minimized.

Copy link
@albrow

albrow Oct 15, 2019

Author Member

Good point. I think this should work since I'll also have access to the Ethereum network ID from the config object. I'll update this PR.

integration-tests/browser/src/index.ts Outdated Show resolved Hide resolved
@albrow albrow requested a review from fabioberger Oct 15, 2019
@albrow albrow merged commit 1ce232d into development Oct 15, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the feature/custom-contract-addresses branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.