Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: Update kovan DevUtils.sol address #446

Merged
merged 3 commits into from Oct 16, 2019
Merged

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Oct 15, 2019

Apparently the fixed DevUtils.sol contract has not been re-deployed to Kovan until now. This PR updates it's address.

@@ -2,6 +2,12 @@

This changelog is a work in progress and may contain notes for versions which have not actually been released. Check the [Releases](https://github.com/0xProject/0x-mesh/releases) page to see full release notes and more information about the latest released versions.

## v5.0.1-beta

This comment has been minimized.

Copy link
@albrow

albrow Oct 15, 2019

Member

@fabioberger Have you thought about what to call the next version? I was assuming we would use something like 5.0.1-beta-0xv3 to show that it is designed for v3 of the protocol but still have a way to indicate breaking changes. It looks like on Docker we just tagged the image as 0xV3 which I don't like as much since there is no way to indicate breaking changes.

I think on npm we used 5.0.0-beta but a special dist tag which is closer to the right approach. However I'm not sure what would happen if there is a mismatch between the versions that support v3 and the ones that don't. For example, is it possible to have a version 5.0.1-beta that is only available if you use the dist tag?

This comment has been minimized.

Copy link
@fabioberger

fabioberger Oct 16, 2019

Author Contributor

Yeah, this is a good point. I guess we should just suffix with -0xv3. I'll do that in the CHANGELOG and when we publish to Docker hub / NPM. The NPM tag will still be protocolV3 to remain consistent with the rest of the 0x packages.

@albrow
albrow approved these changes Oct 15, 2019
Copy link
Member

albrow left a comment

Change itself is simple enough. Just asked a question about what to call the next version.

@fabioberger fabioberger merged commit e33ff6c into 0xV3 Oct 16, 2019
1 check was pending
1 check was pending
ci/circleci: build CircleCI is running your tests
Details
@fabioberger fabioberger deleted the updateKovanDevUtilsAddress branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.