Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement order pinning #474

Merged
merged 13 commits into from Oct 28, 2019

Conversation

@albrow
Copy link
Member

albrow commented Oct 25, 2019

Fixes #469. The new feature is an optional parameter for RPC requests and the addOrdersAsync method in the TypeScript bindings, so this PR maintains backwards compatibility.

albrow added 4 commits Oct 24, 2019
@albrow albrow changed the title Implement order pinning WIP: Implement order pinning Oct 25, 2019
albrow added 5 commits Oct 25, 2019
@albrow albrow marked this pull request as ready for review Oct 25, 2019
@albrow albrow changed the title WIP: Implement order pinning Implement order pinning Oct 25, 2019
@albrow albrow requested a review from fabioberger Oct 25, 2019
Copy link
Contributor

fabioberger left a comment

This is looking good! Can you also add support for the isPinned option to the TS client?

CHANGELOG.md Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
albrow added 3 commits Oct 25, 2019
@albrow

This comment has been minimized.

Copy link
Member Author

albrow commented Oct 25, 2019

This is looking good! Can you also add support for the isPinned option to the TS client?

Nice catch! Just added.

@albrow albrow requested a review from fabioberger Oct 25, 2019
Copy link
Contributor

fabioberger left a comment

LGTM once pinned count is added to stats response.

@albrow albrow force-pushed the feature/order-pinning branch from edf0470 to 0d9b950 Oct 25, 2019
@albrow albrow merged commit 0b773a4 into development Oct 28, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the feature/order-pinning branch Oct 28, 2019
@albrow albrow referenced this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.