Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh 0x V2: Change mentions of `networkID` to `chainID` #485

Merged
merged 5 commits into from Nov 1, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Oct 31, 2019

Replace mentions of networkID with chainID and start referencing Ganache by chainID 1337 not networkID 50.

@fabioberger fabioberger changed the base branch from master to development Oct 31, 2019
@fabioberger fabioberger changed the title Mesh 0x V2: Refactor mentions of `networkID` with `chainID` Mesh 0x V2: Change mentions of `networkID` to `chainID` Oct 31, 2019
@fabioberger fabioberger requested a review from albrow Oct 31, 2019
fabioberger added 3 commits Oct 31, 2019
@albrow albrow self-requested a review Nov 1, 2019
@albrow
albrow approved these changes Nov 1, 2019
@fabioberger fabioberger merged commit c27b592 into development Nov 1, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the refactor/switchToUsingChainId branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.