Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPCAddr option for the JSON-RPC API #487

Merged
merged 4 commits into from Nov 1, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 1, 2019

Allows choosing the JSON-RPC API listening interface and port. Remove RPCPort as it is no longer needed.

Big thanks to @nfeignon for implementing this feature 馃槃

@albrow albrow marked this pull request as ready for review Nov 1, 2019
Copy link
Contributor

fabioberger left a comment

LGTM once merge conflicts addressed

nfeignon and others added 3 commits Oct 7, 2019
Allows choosing the JSON-RPC API listening interface and port. Remove
RPCPort as it is no longer needed.
@albrow albrow force-pushed the feature/rpc-addr-option branch from 831a4cb to f3a3772 Nov 1, 2019
@albrow albrow merged commit b6a9709 into development Nov 1, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the feature/rpc-addr-option branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.